Skip to content

fix: move argument validation before sys.argv access in mkconcore.py (fixes #267) #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GaneshPatil7517 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix: move argument validation before sys.argv access in mkconcore.py (fixes #267) #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8690784
fix: validate arguments before usage in mkconcore.py (Issue #267)
GaneshPatil7517 Feb 15, 2026
9e8e756
fix: use print+sys.exit for early arg check before logging is configured
GaneshPatil7517 Feb 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions mkconcore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,11 @@ def _resolve_concore_path():
return os.getcwd()
return SCRIPT_DIR

if len(sys.argv) < 4:
print("usage: py mkconcore.py file.graphml sourcedir outdir [type]")
print(" type must be posix (macos or ubuntu), windows, or docker")
sys.exit(1)

GRAPHML_FILE = sys.argv[1]
TRIMMED_LOGS = True
CONCOREPATH = _resolve_concore_path()
Expand Down Expand Up @@ -202,11 +207,7 @@ def _resolve_concore_path():
logging.error(f"{sourcedir} does not exist")
quit()

if len(sys.argv) < 4:
logging.error("usage: py mkconcore.py file.graphml sourcedir outdir [type]")
logging.error(" type must be posix (macos or ubuntu), windows, or docker")
quit()
elif len(sys.argv) == 4:
if len(sys.argv) == 4:
prefixedgenode = outdir+"_" #nodes and edges prefixed with outdir_ only in case no type specified 3/24/21
concoretype = "docker"
else:
Expand Down