fix: move argument validation before sys.argv access in mkconcore.py (fixes #267)#336
Open
GaneshPatil7517 wants to merge 2 commits intoControlCore-Project:devfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes mkconcore.py crashing with IndexError when invoked without enough CLI arguments by moving the len(sys.argv) validation ahead of any sys.argv[...] access.
Changes:
- Move the existing
len(sys.argv) < 4early-exit usage check to beforesys.argv[1],sys.argv[2], andsys.argv[3]are accessed. - Adjust the later branching from
eliftoifsince the earlier check now handles the missing-args case.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pradeeban sir
Summary
Fixes #267 —
mkconcore.pycrashes withIndexErrorwhen run without arguments becausesys.argv[1],sys.argv[2], andsys.argv[3]are accessed before the argument count is validated.Changes
len(sys.argv) < 4check from line ~207 to line ~140, before anysys.argvaccesseliftoifat the original location since the early-exit block was removed above itNo new logic, no style changes, no whitespace modifications. The same validation code is simply relocated earlier.
Diff
Before / After
Before:
python mkconcore.py→IndexError: list index out of rangeAfter:
python mkconcore.py→ prints usage message and exits cleanly