Skip to content

chore: remove redundant main.yaml CI workflow #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luisina-santos wants to merge 3 commits into
base: main
Choose a base branch
from
+6 −81
Open

chore: remove redundant main.yaml CI workflow #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84fbd98
chore: remove redundant main.yaml CI workflow
luisina-santos Jul 16, 2026
fbaecf2
chore: restore push-to-main trigger on ci.yaml
luisina-santos Jul 16, 2026
0b124ae
chore(gitlab): remove redundant go-lint/go-test jobs from ci.yaml
mateoHernandez123 Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 6 additions & 40 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,12 @@
name: Test Baton Gitlab Integration

on: pull_request
on:

@gontzess gontzess Jul 16, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you can also remove the go-test and go-lint jobs in this file those should be covered in the verfiy.yaml from baton-admin

@mateoHernandez123 mateoHernandez123 Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — done in 0b124ae

pull_request:
push:
branches:
- main
Comment on lines +5 to +7

@github-actions github-actions Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Suggestion: This adds a push: branches: [main] trigger, but the only remaining job (test-cloud-version) is now guarded by if: github.event_name == 'pull_request', so it is skipped on push. The push-to-main trigger therefore runs zero jobs and is effectively a no-op. If the intent was to run lint/test on push to main (as main.yaml previously did), that coverage is now missing. (confidence: high)


jobs:

@github-actions github-actions Bot Jul 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟠 Bug: This PR removes the go-lint and go-test jobs from ci.yaml and also deletes main.yaml, which was the only other place those jobs ran. After this change no workflow in the repo runs golangci-lint or go test on pull requests or on push to main — capabilities_and_config.yaml only does go build, and update-dependencies.yaml is a scheduled maintenance job. The PR description says these jobs are "already covered by ci.yaml," but this same diff removes them. Unless a centralized reusable workflow (not present in this repo) runs lint/test, please keep a go-lint/go-test job on pull_request. (confidence: medium-high)

go-lint:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v3
- name: Install Go
uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
- name: Run linters
uses: golangci/golangci-lint-action@v8
with:
version: latest
args: --timeout=3m

go-test:
strategy:
matrix:
platform: [ubuntu-latest, windows-latest]
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout code
uses: actions/checkout@v4
- name: Install Go
if: success()
uses: actions/setup-go@v5
with:
go-version-file: "go.mod"
- name: go tests
run: go test -v -covermode=count -json ./... > test.json
- name: Print go test results
if: always()
run: cat test.json
- name: annotate go tests
if: always()
uses: guyarb/golang-test-annotations@v0.8.0
with:
test-results: test.json

# this test is commented because it fails to run due to lack of memory in ci test.
# test-DC-version:
# runs-on: ubuntu-latest
Expand Down Expand Up @@ -190,6 +155,7 @@ jobs:
# jq --exit-status ".grants[].principal.id.resource == \"${{ env.USER_ID }}\""

test-cloud-version:
if: github.event_name == 'pull_request'
runs-on: ubuntu-latest
env:
BATON_LOG_LEVEL: debug
Expand Down
41 changes: 0 additions & 41 deletions .github/workflows/main.yaml
View file
Open in desktop

This file was deleted.

Loading