chore: remove redundant main.yaml CI workflow

[luisina-santos]

Summary

• Removes .github/workflows/main.yaml, which duplicated the go-lint/go-test jobs already covered by ci.yaml, just triggered on push to main instead of pull_request.

Test plan

• N/A (workflow file deletion only, no code changes)

🤖 Generated with Claude Code

[gontzess]

i think you can also remove the go-test and go-lint jobs in this file those should be covered in the verfiy.yaml from baton-admin

[mateoHernandez123]

Good catch — done in 0b124ae

[github-actions]

Connector PR Review: chore: remove redundant main.yaml CI workflow

Blocking Issues: 1 | Suggestions: 1 | Threads Resolved: 0
Criteria: Criteria status: loaded .claude/skills/ci-review.md from trusted base f561411df06c.
Review mode: full
View review run

Review Summary

Reviewed the full PR diff (workflow-only changes; no Go source, go.mod, or go.sum touched, so no connector/dependency criteria applied). The PR deletes main.yaml and removes the go-lint/go-test jobs from ci.yaml, adds a push: branches: [main] trigger to ci.yaml, and guards test-cloud-version to pull_request events. The net effect is that golangci-lint and go test no longer run on pull requests or on push to main anywhere in this repo.

Security Issues

None found.

Correctness Issues

• .github/workflows/ci.yaml:9 — Removing go-lint/go-test from ci.yaml while deleting main.yaml leaves no workflow running lint or unit tests on pull_request or push to main (other workflows only go build or run on schedule). PR description claims coverage stays in ci.yaml, but this diff removes it.

Suggestions

• .github/workflows/ci.yaml:5-7 — The new push: branches: [main] trigger runs no jobs, since the only remaining job (test-cloud-version) is guarded to pull_request only; the push trigger is effectively a no-op.

Prompt for AI agents

Verify each finding against the current code and only fix it if needed.

## Correctness Issues

In .github/workflows/ci.yaml:
- Around line 9 (jobs section): This PR removed the go-lint and go-test jobs from
  ci.yaml and deleted .github/workflows/main.yaml, so no workflow now runs
  golangci-lint or go test on pull requests or on push to main. Confirm whether a
  centralized/reusable workflow covers lint+test; if not, re-add a go-lint and a
  go-test job triggered on pull_request (matching the previous ubuntu/windows
  matrix) so PRs still get linted and unit-tested.

## Suggestions

In .github/workflows/ci.yaml:
- Around lines 5-7 (the added push branches main trigger): the only remaining job
  test-cloud-version is guarded by an if event_name pull_request condition, so the
  push-to-main trigger runs zero jobs. Either add a job that should run on push to main
  or drop the push trigger to avoid a no-op workflow run.

[github-actions]

No blocking issues found.

[github-actions]

🟠 Bug: This PR removes the go-lint and go-test jobs from ci.yaml and also deletes main.yaml, which was the only other place those jobs ran. After this change no workflow in the repo runs golangci-lint or go test on pull requests or on push to main — capabilities_and_config.yaml only does go build, and update-dependencies.yaml is a scheduled maintenance job. The PR description says these jobs are "already covered by ci.yaml," but this same diff removes them. Unless a centralized reusable workflow (not present in this repo) runs lint/test, please keep a go-lint/go-test job on pull_request. (confidence: medium-high)

[github-actions]

🟡 Suggestion: This adds a push: branches: [main] trigger, but the only remaining job (test-cloud-version) is now guarded by if: github.event_name == 'pull_request', so it is skipped on push. The push-to-main trigger therefore runs zero jobs and is effectively a no-op. If the intent was to run lint/test on push to main (as main.yaml previously did), that coverage is now missing. (confidence: high)

[github-actions]

Blocking issues found — see review comments.