fix(review): #1219 review findings, round 1 - #1223
Merged
Merged
Conversation
…inel that will be displayed Thread: #1219 (comment) The Placeholder values paragraph in docs/features/cmdb-import.md now says 2036-01-01 is the CMDB's stand-in for no end-of-life date, that it is stored as the usage phase-out date and shown like a real one (an application reads as "Phased out" once it is reached), and that a re-import with Update existing records fills it where it was empty before. Class sweep: git grep -n 'End-of-Life Functioneel' -- docs/ found only cmdb-import.md (the paragraph and the column table). No Dutch or other copy documents the placeholder, so nothing else changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the phase is per usage Thread: #1219 (comment) In the Placeholder values paragraph of docs/features/cmdb-import.md: - an update with Update existing records on also replaces a different stored phase-out date, including one set by hand (merge() skips only createOnly fields, and the usage profile lists only interneAnnotation); - the "Phased out" phase belongs to the usage, not the application (derivePhase works per gebruik). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for the round-1 review of #1219 (#1219 (review)). Merge into
fix/cmdb-import-eol-as-is, then re-request the review; nothing here is merged by the reviewer.Findings → commits
3dd75bb,0160aeddocs/features/cmdb-import.mdsays 2036-01-01 is the CMDB's stand-in for "no date", is stored as the usage's phase-out date and shown like a real one, and that a re-import with Update existing records fills it where empty and replaces a different stored date.Checks run on this branch
git diff --check 42c29f72..HEAD→ cleanextract-features.py --app-root . --check(the Features Check script) → regeneratingdocs/features.jsonshows only thelicense-and-seat-trackingstatus change development made in fix(ci): regenerate features.json and clear the CodeQL alerts on the beta promotion #1218, the same as on fix(cmdb-import): map the CMDB export as the file has it, and resolve the #1209 review #1219's head; this branch adds no difference.0160aed; every sentence checked againstmerge()/createOnly/neverWrittenin the import profile andderivePhase().node_modulesin the checkout.🤖 Generated with Claude Code