Skip to content

Rename signup navigation to Join Us #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Hilo-Hilo merged 1 commit into from
Sep 4, 2026
Merged

Rename signup navigation to Join Us #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions scripts/validate-seo-build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,7 @@ for (const page of pages) {
assert.doesNotMatch(html, /https:\/\/forms\.gle\/EQmWP1JWzDzrFji79/);
assert.doesNotMatch(html, /https:\/\/linktr\.ee\/compbioatberkeley/);
assert.ok(html.includes('href="https://linktr.ee/UCB_CompBio"'));
assert.match(html, />Join Us<\/a>/, `${page.path} navigation must label the signup route “Join Us”`);
if (page.path === "/") {
assert.ok(mainTextLength >= 2000, `home SSR text must be substantial; received ${mainTextLength}`);
const contentEfficiency = visibleText(html).length / html.length;
Expand Down
2 changes: 1 addition & 1 deletion src/components/Footer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const quickLinks = [
{ name: "calendar", path: "/calendar/" },
{ name: "collaborations", path: "/collaborations/" },
{ name: "officers", path: "/officers/" },
{ name: "sign up", path: "/signup/" },
{ name: "Join Us", path: "/signup/" },
{ name: "contact", path: "/contact/" },
{ name: "privacy", path: "/privacy/" },
{ name: "developers", path: "/developers/" },
Expand Down
4 changes: 2 additions & 2 deletions src/components/Navigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ const Navigation = () => {
aria-current={isActive("/signup/") ? "page" : undefined}
className="rounded bg-primary px-3.5 py-2 text-xs font-bold text-primary-foreground transition-colors hover:bg-primary/90 hover:text-primary-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background active:translate-y-px"
>
sign up
Join Us
</Link>
</div>

Expand All @@ -121,7 +121,7 @@ const Navigation = () => {

{isOpen && (
<div id="mobile-navigation" className="border-t border-border py-2 lg:hidden">
{[...navItems, { name: "sign up", path: "/signup/" }].map((item) => (
{[...navItems, { name: "Join Us", path: "/signup/" }].map((item) => (
<Link
key={item.path}
to={item.path}
Expand Down