Repository navigation
fix(diagnostics): classify encrypted-database failures and surface damaged receipt chains - #316
Open
Coding-Dev-Tools wants to merge 6 commits into
Open
Coding-Dev-Tools wants to merge 6 commits into
Coding-Dev-Tools wants to merge 6 commits into
Conversation
A user-host report showed a forked receipt chain followed by the provider going unavailable with EncryptionError. Since 1.7.6 receipt damage is audit-only, but there was no supported way to see it outside the host log, and every encrypted-open failure was reported as a wrong key. Extract receipt_chain_state/verify_receipt_chain so the install doctor verifies chains read-only through its own connection and reports damage with recovery guidance, bounded to 20k receipts and 25 scopes. Classify EncryptionError with stable codes; driver text is still never rendered because it can echo paths or the PRAGMA key. Refresh the checksum-bound offline evidence artifact and its rendered SVG/PNG surfaces because tracked producer files changed. Refs discussion #151. Agent: opencode
Main now carries the 1.7.12 release, the sync/manifest hardening, and the canonical evidence artifact. Rebind the receipt-diagnostics evidence to the three producer files main changed (__init__, routes/v2_api, chunking_eval), recompute the suite digest and artifact SHA, and repin the README, benchmark guide, tests, and both rendered SVG/PNG pairs.
The merge that brought main's 1.7.12 release into this branch rewrote BENCHMARKS.md, README.md, and both benchmark SVGs with CRLF line endings, which changed their exact bytes under the repository's -text policy, and left the PNG provenance hashes bound to the pre-normalization SVG bytes. Restore LF bytes, rebuild the sidecar with its required LF terminator, and re-stamp the artifact/SVG SHA-256 tEXt chunks so the checksum-bound evidence tests compare the committed bytes. Agent: opencode
The embedder check inferred exact mode from a non-empty embed_model, while the factory uses the explicit require_exact_backends setting. Honor the same policy so a configured model may fall back when exact mode is off, and a deployment that requires exact backends is checked strictly even with the default model. The regression test sets the policy it exercises. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
CVE-2026-115557 in the Python 3.11.17 runtime is fixed in 3.11.18. Pin the new multi-arch digest so the release grype gate can pass. Co-authored-by: coding-dev-tools <coding-dev-tools@users.noreply.github.com> Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bring the branch current with main for review. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Coding-Dev-Tools
force-pushed
the
main
branch
2 times, most recently
from
November 4, 2026 06:12
3d330e8 to
8ef46b6
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserves the receipt-chain diagnostics work from the closed #310 and adds the doctor exactness fix:
EncryptionErrornow carries stable codes (database_damaged,database_busy,database_unavailable,key_rejected,driver_missing, key-file codes) so a damaged or locked SQLCipher file is no longer reported as a wrong key.engraphis-init --checkverifies operation-receipt chains through its own read-only connection and reports damage with recovery guidance, bounded to 25 scopes and 20k receipts. Receipt damage remains audit-only; memory writes and recall continue.settings.require_exact_backends, matching the factory, instead of inferring exact mode from a non-emptyembed_model.Verification
tests/test_receipts.py,tests/test_init.py,tests/test_encryption_dependency.py— passed.main(6c75758a).This supersedes closed #310. The earlier PR was closed after its branch was rebased and pushed past the closed head.
Agent: commandcode