Repository navigation
fix(sync,manifest): record sync authorization denial and support public-offer cloud contract - #306
Closed
Coding-Dev-Tools wants to merge 5 commits into
Closed
Coding-Dev-Tools wants to merge 5 commits into
Coding-Dev-Tools wants to merge 5 commits into
Conversation
…ic-offer cloud contract - Record authoritative entitlement denial when POST /api/sync/run fails with 401/402/403, and return account_url() when connected to prevent lapsed Team users from misrouting to Pro checkout - Accept schema 'engraphis-public-offer/v1' in scripts/check_commercial_manifest.py --cloud-contract to cleanly validate against engraphis-cloud - Add regression test in tests/test_sync_dashboard.py Agent: antigravity
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Owner
Author
|
The failing gate is |
The registered artifact binds the SHA-256 of every Python file under engraphis/ and eval/, so the sync authorization-denial change in engraphis/routes/v2_api.py invalidated it. test_benchmark_evidence.py failed the same assertion on Python 3.10 through 3.14, in the numpy-only 3.9 core floor job, and in the coverage gate, which was the single shared cause of every red job on this PR. Regenerate the immutable artifact with scripts/export_offline_evidence (new basename, 590-file manifest, identical deterministic fixture aggregates) and re-pin the artifact SHA-256 and the fixture-suite digest in README, BENCHMARKS, and both rendered SVG/PNG pairs. The PNGs are rasterized at their exact canvas sizes through headless Chromium because this host has no libcairo; the repo's own metadata writer still binds both checksums. Also pass retention_supervisor="none" to the chunking fixture service. Its background supervisor pruned memories while the fixture ran, so the reported context reduction drifted between 71.1 and 72.3 percent and a fresh run could not reproduce a recorded artifact. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
regenerate/normalize rather than use the host checkout bytes: engraphis/routes/v2_api.py was rewritten with CRLF by a Windows editor, so the artifact recorded the CRLF digest while every Linux CI checkout hashes the LF blob (.gitattributes pins *.py to eol=lf). That single stale entry broke test_benchmark_evidence.py on Python 3.10-3.14, the numpy-only 3.9 core floor, and the coverage gate. Normalize the producer file to LF, re-record its digest, recompute the suite digest, and re-pin the artifact SHA plus both PNG provenance chunks. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Resolve the benchmark evidence surfaces to main's 1.7.12 release artifact, which already binds the sync authorization-denial producer bytes, and drop the superseded local re-pin of the previous artifact. Co-authored-by: CommandCodeBot <noreply@commandcode.ai>
Owner
Author
|
Decision: close as already shipped. The titled sync/manifest code fix is identical in main; the only remaining diff is generated benchmark-evidence JSON. The artifact can be regenerated if a future evidence audit needs it. Branch retained for reference. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses release-readiness edge cases in \engraphis\ for Pro and Team features:
Agent: antigravity