Repository navigation
feat: parity batch 2 (review follow-ups, CFN in-progress states, OCI LB backend TLS, ...) #2524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
agbishop
wants to merge
93
commits into
main
Choose a base branch
from
feat/parity-next2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75,890
−1,889
Open
Changes from all commits
Commits
Show all changes
93 commits
Select commit
Hold shift + click to select a range
5c57b22
fix(azurearm): slot function lookups query the slot's data-plane app
8672230
fix(gcpdatastore): commit-time floor, key collisions, GQL quoting, mu…
0bc07ed
test: satisfy fieldalignment and golines
870ee56
feat(cloudformation): default 300ms provisioning delay so stacks show…
d1752ab
style(cloudformation): format provisioning delay settings and test
2f78021
Merge branch 'fix/cfn-default-delay' into feat/parity-next2
b64ccae
fix(ociloadbalancer): honour verifyPeerCertificate=false for loopback…
ec76f04
test(ociloadbalancer): satisfy fieldalignment and shadow
85cb50c
Merge branch 'fix/ocilb-loopback-tls' into feat/parity-next2
587b3d7
test: bind remaining service test listeners on Port 0 instead of prob…
19a50cf
docs(ociloadbalancer): regenerate README
357e919
style(neptune): shorten startCypherFront doc
a5c3f47
Merge branch 'test/port-helpers-2' into feat/parity-next2
64b1a29
Merge remote-tracking branch 'origin/main' into feat/parity-next2
fc42009
feat(dsql): PostgreSQL data plane behind clusters (IAM-token proxy, a…
44b3ca6
fix(dsql): lint fixes and parallel data-plane subtests
13d6388
fix(dsql): gosec findings
4aa0afc
fix(dsql): drop credential-looking constants
cac3a36
fix(dsql): rename algorithm constant
9e8eeeb
feat(transcribe): write real transcript documents to S3 and add an op…
e066261
Merge branch 'parity/dsql-dataplane' into feat/parity-next2
ba689ee
feat(cognitoidp): LocalStack /_aws/cognito-idp hosted-UI alias and _c…
e938efb
fix(cognitoidp): wrap long test line
943c6bc
Merge branch 'parity/transcribe' into feat/parity-next2
d9db2f8
fix(transcribe): close idle download connections after fetching a Vos…
a2a1ff5
feat(deploy): Helm chart for Kubernetes with k3s install test
0dce91c
Merge branch 'parity/cognito-alias' into feat/parity-next2
0dedfe5
feat(deploy): satisfy lint in helm chart tests
0f81ff0
feat(deploy): tidy helm install test
129bcee
feat(deploy): track chart NOTES.txt past the *.txt ignore rule
633c7af
Merge branch 'feat/helm-chart' into fix/nonroot-image
d848571
Merge branch 'feat/helm-chart' into feat/parity-next2
90f6581
feat(ui): Azure Entra ID & access dashboard page
c0ec1fa
feat(ui): address lint findings in the Entra proxies
d1c98bf
feat(ui): wire the Graph handler beside the other dashboard handlers
ebec826
feat(ui): wrap a long Entra proxy test line
68eb2b0
Merge branch 'feat/dash-azure-entra' into feat/parity-next2
cfe4938
fix(docker): run the release image as non-root (distroless static, UI…
47ff620
feat(gcpstorage): notifications, HMAC keys, signed URLs, retention, l…
369779f
fix(gcpstorage): lint and structure cleanups for the new enforcement …
d81a521
test(helm): use testclient instead of http.DefaultClient
e15b6c9
fix(transcribe): reject '..' archive entries before joining (CodeQL g…
15447c0
Merge branch 'fix/nonroot-image' into feat/parity-next2
6893aa5
Merge branch 'parity/gcp-next3' into feat/parity-next2
5e4e25c
feat(ocidns): OCI DNS control plane and authoritative data plane
ef34a56
feat(ocidns): lint cleanups and test restructuring
c1c9fb3
Merge branch 'parity/oci-dns' into feat/parity-next2
f0b0f18
feat(cloudformation): async delete, execute, rollback, nested and sta…
fe8ca33
Merge branch 'fix/cfn-async-rest' into feat/parity-next2
6023d16
feat(azurearm): application gateways, WAF policies, Azure Firewalls, …
fada55b
feat(ui): GCP Compute Engine dashboard page with LB, Cloud Armor, net…
0683cdb
docs(gcpcompute): regenerate README after dashboard page
cbe2c79
style(dashboard): static compute proxy errors, formatting
d298156
feat(azurearm): terraform fixture and parity notes for gateways and f…
00f9109
feat(azurearm): lint cleanups for gateways and firewalls
c827f5f
Merge branch 'feat/dash-gcp-compute' into feat/parity-next2
9829ca5
test(azurearm): use an unmodelled type in generic list index tests
2a51501
docs(azurearm): regenerate readmes
2680fe5
fix(docker): Dockerfile.test builds with the classic builder testcont…
a2dd249
Merge branch 'parity/azure-appgw' into feat/parity-next2
a90f63d
fix(appconfig): share one clock reading between deployment tick and r…
acb55f6
fix(elbv2): close pooled proxy and probe connections on shutdown
11c4abe
test(elbv2): satisfy lint for idle-conn test and tick doc
34109ed
feat(ocidatabase): OCI Autonomous Database control plane and Oracle F…
cf19918
Merge remote-tracking branch 'origin/main' into feat/parity-next2
b9be336
feat(ocidatabase): parity audit, docs, persistence inventory
156e250
chore(deps): tidy desktop go.sum after go-jose bump
e7a3c74
test(ocidatabase): keep the engine switch table small for fieldalignment
ca468df
Merge branch 'parity/oci-adb' into feat/parity-next2
a4b6b1c
fix(ecs): tolerate duplicate runner stops in Reset test
bc97269
feat(ui): OCI DNS and Autonomous Database dashboard pages
bb8ca13
feat(ui): satisfy lint for the OCI DNS and Database proxies
92ca79e
Merge branch 'feat/dash-oci-dns-db' into feat/parity-next2
2c23e1a
fix(swf): compute retention cutoff in elapsed 24h days, not local cal…
09909af
Merge branch 'fix/swf-retention-utc' into feat/parity-next2
8f7af2e
feat(dsql): enforce documented transaction, index and connection limits
bc54164
feat(dms): selection filters, column transformations, S3 source, secr…
d772afd
test(dsql): SDK-driven data plane integration test; PARITY update
90b8ea3
test(dsql): use the integration HTTP client in the data plane test
ea845bb
test(dsql): lint fixes
934d160
docs(dsql): regenerate README
7b1e027
feat(dms): lint cleanups, replication snapshot settling, golden and docs
1c3f726
Merge branch 'parity/dms-depth' into feat/parity-next2
dba4fb2
feat(lambdaweb): Lambda Web Functions service with endpoint data plane
de6c076
test(lambdaweb): routing corpus rows and docker-gated real-app test
4a0ac17
test(lambdaweb): use an explicit HTTP client in the integration test
bd7ba5c
Merge branch 'parity/lambda-web' into feat/parity-next2
500a2a6
feat(ocifilestorage): service VNICs in OCI Core for mount targets
2e28ff9
feat(ocifilestorage): OCI File Storage control plane and NFSv3 data p…
1732e57
Merge branch 'parity/oci-filestorage' into feat/parity-next2
e3c1c76
feat(ui): Azure Networking dashboard page
2c648e5
feat(ui): satisfy lint in the Networking proxy
4605715
Merge branch 'feat/dash-azure-netsec' into feat/parity-next2
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,14 @@ | ||
| # Lightweight test image — expects a pre-built static binary at bin/gopherstack-linux | ||
| # (from `task build-linux`; this is a separate path from `task build`'s bin/gopherstack | ||
| # so the two targets can't clobber each other — see gopherstack-gooq). | ||
| FROM scratch | ||
| COPY bin/gopherstack-linux /root/gopherstack | ||
| # Lightweight test image: expects a pre-built static binary at bin/gopherstack-linux | ||
| # (from `task build-linux`; separate from `task build`'s bin/gopherstack — see gopherstack-gooq). | ||
| # Same non-root layout as the release image. Must build with the classic (non-BuildKit) | ||
| # builder testcontainers uses: no $BUILDPLATFORM, no COPY --chmod (the binary is already 0755). | ||
| FROM alpine:3.22@sha256:2e0b81d60597f449baa56dc25d355367869d2dca4cd57e866f1e2b52af3eb55f AS state | ||
| RUN mkdir /data | ||
|
|
||
| FROM gcr.io/distroless/static:nonroot@sha256:25ac8f0c3b2334a9eb05452266bd4697864a8c8ef0ef71e5e6480d7f92868329 | ||
| COPY --from=state --chown=65532:65532 /data /data | ||
| COPY --chown=0:0 bin/gopherstack-linux /usr/local/bin/gopherstack | ||
| USER 65532:65532 | ||
| EXPOSE 8000 | ||
| EXPOSE 1883 | ||
| CMD ["/root/gopherstack"] | ||
| CMD ["/usr/local/bin/gopherstack"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .git | ||
| *.swp | ||
| *.bak | ||
| *.tmp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| apiVersion: v2 | ||
| name: gopherstack | ||
| description: Gopherstack, a local multi-cloud (AWS, Azure, GCP, OCI) service emulator | ||
| type: application | ||
| version: 0.1.0 | ||
| appVersion: "1.9.1" | ||
| kubeVersion: ">=1.25.0-0" | ||
| home: https://github.com/blackbirdworks/gopherstack | ||
| sources: | ||
| - https://github.com/blackbirdworks/gopherstack | ||
| keywords: | ||
| - aws | ||
| - emulator | ||
| - localstack | ||
| - testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| Gopherstack {{ .Chart.AppVersion }} is deploying as {{ include "gopherstack.fullname" . }}. | ||
|
|
||
| Point AWS SDKs and the CLI at the service: | ||
| {{- if .Values.ingress.enabled }} | ||
| {{- range .Values.ingress.hosts }} | ||
| export AWS_ENDPOINT_URL=http{{ if $.Values.ingress.tls }}s{{ end }}://{{ .host }} | ||
| {{- end }} | ||
| {{- else if eq .Values.service.type "NodePort" }} | ||
| export NODE_PORT=$(kubectl get svc {{ include "gopherstack.fullname" . }} -n {{ .Release.Namespace }} -o jsonpath='{.spec.ports[0].nodePort}') | ||
| export AWS_ENDPOINT_URL=http://<node-address>:$NODE_PORT | ||
| {{- else if eq .Values.service.type "LoadBalancer" }} | ||
| export AWS_ENDPOINT_URL=http://$(kubectl get svc {{ include "gopherstack.fullname" . }} -n {{ .Release.Namespace }} -o jsonpath='{.status.loadBalancer.ingress[0].ip}'):{{ .Values.service.port }} | ||
| {{- else }} | ||
| kubectl port-forward -n {{ .Release.Namespace }} svc/{{ include "gopherstack.fullname" . }} {{ .Values.service.port }}:{{ .Values.service.port }} | ||
| export AWS_ENDPOINT_URL=http://localhost:{{ .Values.service.port }} | ||
| {{- end }} | ||
| export AWS_ACCESS_KEY_ID=test AWS_SECRET_ACCESS_KEY=test AWS_DEFAULT_REGION={{ .Values.config.region }} | ||
|
|
||
| In-cluster endpoint: http://{{ include "gopherstack.fullname" . }}.{{ .Release.Namespace }}.svc.cluster.local:{{ .Values.service.port }} | ||
| Health: {{ .Values.probes.path }} | ||
| {{- if not .Values.persistence.enabled }} | ||
|
|
||
| State is in memory and is lost when the pod restarts. Set persistence.enabled=true to keep it. | ||
| {{- end }} | ||
| {{- if not .Values.dind.enabled }} | ||
|
|
||
| Docker-backed engines (RDS, EKS, Lambda containers, ...) need a container runtime and run | ||
| as stubs in this pod. Set dind.enabled=true and config.engines=docker to use a DinD sidecar. | ||
| {{- end }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| {{- define "gopherstack.name" -}} | ||
| {{- default .Chart.Name .Values.nameOverride | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.fullname" -}} | ||
| {{- if .Values.fullnameOverride -}} | ||
| {{- .Values.fullnameOverride | trunc 63 | trimSuffix "-" -}} | ||
| {{- else -}} | ||
| {{- $name := default .Chart.Name .Values.nameOverride -}} | ||
| {{- if contains $name .Release.Name -}} | ||
| {{- .Release.Name | trunc 63 | trimSuffix "-" -}} | ||
| {{- else -}} | ||
| {{- printf "%s-%s" .Release.Name $name | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.chart" -}} | ||
| {{- printf "%s-%s" .Chart.Name .Chart.Version | replace "+" "_" | trunc 63 | trimSuffix "-" -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.labels" -}} | ||
| helm.sh/chart: {{ include "gopherstack.chart" . }} | ||
| {{ include "gopherstack.selectorLabels" . }} | ||
| app.kubernetes.io/version: {{ .Chart.AppVersion | quote }} | ||
| app.kubernetes.io/managed-by: {{ .Release.Service }} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.selectorLabels" -}} | ||
| app.kubernetes.io/name: {{ include "gopherstack.name" . }} | ||
| app.kubernetes.io/instance: {{ .Release.Name }} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.serviceAccountName" -}} | ||
| {{- if .Values.serviceAccount.create -}} | ||
| {{- default (include "gopherstack.fullname" .) .Values.serviceAccount.name -}} | ||
| {{- else -}} | ||
| {{- default "default" .Values.serviceAccount.name -}} | ||
| {{- end -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.image" -}} | ||
| {{- printf "%s:%s" .Values.image.repository (default .Chart.AppVersion .Values.image.tag) -}} | ||
| {{- end -}} | ||
|
|
||
| {{- define "gopherstack.pvcName" -}} | ||
| {{- default (include "gopherstack.fullname" .) .Values.persistence.existingClaim -}} | ||
| {{- end -}} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disable credential persistence in checkout.
This job runs
go testand never pushes to git. The checkout step still writes the token to.git/configby default. Setpersist-credentials: false. This also clears the zizmorartipackedwarning.🔒️ Proposed fix
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1 with: token: ${{ env.GH_CI_TOKEN }} + persist-credentials: falseCommittable suggestion
zizmor (1.30.1)
[warning] 869-871: credential persistence through GitHub Actions artifacts (artipacked): does not set persist-credentials: false
(artipacked)
Source: Linters/SAST tools