Skip to content

refactor(cli): make getServiceProviders funlen-proof (unblocks new-service PRs) #2239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
agbishop merged 1 commit into from
Jun 13, 2026
+16 −1
Merged

refactor(cli): make getServiceProviders funlen-proof (unblocks new-service PRs) #2239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2586,7 +2586,14 @@ func initializeServices(appCtx *service.AppContext) ([]service.Registerable, err

// getServiceProviders returns the list of all available service providers.
func getServiceProviders() []service.Provider {
return append([]service.Provider{
return append(getCoreServiceProviders(), getRemainingServiceProviders()...)
}

// getCoreServiceProviders returns the foundational service providers.
// Extracted from getServiceProviders to satisfy the funlen limit and to
// give the inline registration list headroom as new services are added.
func getCoreServiceProviders() []service.Provider {
return []service.Provider{
&ddbbackend.Provider{},
&s3backend.Provider{},
&ssmbackend.Provider{},
Expand All @@ -2598,6 +2605,14 @@ func getServiceProviders() []service.Provider {
&secretsmanagerbackend.Provider{},
&lambdabackend.Provider{},
&ebbackend.Provider{},
}
}

// getRemainingServiceProviders returns the remaining service providers. New
// services should be registered in getMostRecentServiceProviders (the tail of
// the chain), not here, to keep this function under the funlen limit.
func getRemainingServiceProviders() []service.Provider {
return append([]service.Provider{
&apigwbackend.Provider{},
&cwlogsbackend.Provider{},
&sfnbackend.Provider{},
Expand Down
Loading