refactor(cli): make getServiceProviders funlen-proof (unblocks new-service PRs)#2239
Merged
Conversation
Extract the foundational providers into getCoreServiceProviders so the inline registration list stays under the 100-line funlen limit. New services register in getMostRecentServiceProviders (chain tail). Unblocks new-service PRs that all tripped the same shared-cli.go funlen error. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
📊 Code Coverage Report
Tip This project maintains a minimum coverage threshold of 85%. Maintain or improve coverage on new code to ensure long-term stability. Last updated: Sat, 13 Jun 2026 05:24:23 GMT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every new-service PR (#2232 #2235 #2236 #2238) fails CI
lintidentically:Each new service appends to the inline slice in
getServiceProviders, overflowing the funlen limit. Polecats kept fixing their service files, missing the real cause in sharedcli.go.Fix
Extract the 11 foundational providers into
getCoreServiceProviders(); body becomesgetRemainingServiceProviders(). Tail + chain untouched so in-flight service PRs rebase cleanly.getMostRecentServiceProviders()(chain tail)go build ./...clean, goimports appliedAfter merge, rebase #2232/#2235/#2236/#2238 — funlen clears.
🤖 Generated with Claude Code