feat(cleanrooms): implement AWS Clean Rooms service (go-ca7c)#2236
Closed
agbishop wants to merge 16 commits into
Closed
feat(cleanrooms): implement AWS Clean Rooms service (go-ca7c)#2236agbishop wants to merge 16 commits into
agbishop wants to merge 16 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Add services/cleanrooms with complete 88-op parity: - interfaces.go: StorageBackend interface for all resource types - backend.go: InMemoryBackend with nested maps, lockmetrics, ARN helpers - handler.go: REST path classifier + dispatch for all 88 operations - provider.go: service.Provider integration - sdk_completeness_test.go: verifies all SDK ops are covered - handler_test.go: table-driven CRUD and tag tests Register CleanRooms provider in cli.go. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Prior WIP checkpoint committed unresolved merge conflict markers in services/pipes/ and services/cloudformation/resources_phase3.go. Restore all affected files to the main branch state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Extract classifyCollaboration sub-cases into helpers to reduce gocognit complexity (57→<20 for classifyCollaboration, 97→<20 for classifyMembership) - Extract classifyMemCTAssocAnalysisRule to reduce cyclop in classifyMemCTAssociations (16→<15) - Consolidate batch-* collaboration switch cases to reduce classifyCollaboration cyclop (20→<15) - Split buildOpHandlers (276 lines) into buildCollaborationHandlers, buildMembershipHandlers, buildConfiguredTableHandlers, buildResourceHandlers - Rename unused parameter c→_ in buildOpHandlers (revive) - Break long lines >120 chars (lll) - Add missing blank line before comment (goimports) - Add blank lines before return opUnknown statements (nlreturn) - Use maps.Copy for map merging (modernize) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
agbishop
force-pushed
the
polecat/amber/go-ca7c@mqbpzmle
branch
from
2ac259c to
ba6fbb9
Compare
Module was missing from go.mod causing sdk_completeness_test.go to fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Consolidated into the single mega PR #2227 (parity/mega-v2) per request — one branch to prevent CI spam. Work preserved there. |
auto-merge was automatically disabled
June 13, 2026 11:57
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement new services/cleanrooms with full AWS parity.
Implementation
API Coverage
Testing
Verification