Skip to content

fix(eventhub): correct checkpoint migration sample #49763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(eventhub): correct checkpoint migration sample #49763

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions sdk/eventhub/azure-eventhub/migration_guide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ if __name__ == "__main__":
# The checkpoint blobs require a specific naming scheme to be valid for use with the
# V5 CheckpointStore.
prefix = "{}/{}/{}/checkpoint/".format(
EVENT_HUB_FULLY_QUALIFIED_NAMESPACE.lower(),
EVENT_HUB_HOSTNAME.lower(),
EVENT_HUB_NAME.lower(),
EVENT_HUB_CONSUMER_GROUP.lower(),
)
Expand All @@ -344,9 +344,13 @@ if __name__ == "__main__":
except:
pass

# Translate each legacy checkpoint, storing offset and sequence data into correct
# blob to align with V5 BlobCheckpointStore.
# Translate each legacy checkpoint, storing offset and sequence data into the correct
# blob to align with V5 BlobCheckpointStore. Partitions without a checkpoint yet
# have no offset or sequence number to migrate.
for checkpoint in legacy_checkpoints:
if checkpoint["offset"] is None or checkpoint["sequence_number"] is None:
continue

metadata = {
"offset": str(checkpoint["offset"]),
"sequencenumber": str(checkpoint["sequence_number"]),
Expand Down
Loading