Repository navigation
fix(eventhub): correct checkpoint migration sample - #49763
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Open
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Slai.life (huong8373tt-beep) wants to merge 1 commit into
Conversation
Slai.life (huong8373tt-beep)
marked this pull request as draft
October 29, 2026 21:41
github-actions
Bot
added
Community Contribution
Contributor
|
Thank you for your contribution Slai.life (@huong8373tt-beep)! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the documentation-only checkpoint migration sample fixes.
No open issues 🎉
What changed in this PR
Corrects the Event Hubs v1-to-v5 checkpoint migration sample to address #49723. This documentation-only change does not alter SDK APIs.
Changes:
- Uses the defined
EVENT_HUB_HOSTNAMEvariable when building checkpoint blob names. - Skips legacy leases whose offset or sequence number is
None, preventing invalid checkpoint metadata.
| File | Description |
|---|---|
sdk/eventhub/azure-eventhub/migration_guide.md |
Fixes the hostname reference and guards against migrating leases without checkpoint data. |
Review effort: Balanced
|
Azure Pipelines: Successfully started running 1 pipeline(s). 10 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Slai.life (huong8373tt-beep)
marked this pull request as ready for review
October 29, 2026 21:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EVENT_HUB_HOSTNAMEvalue when building migrated checkpoint names."None"checkpoint metadata.Fixes #49723.
Validation
EVENT_HUB_HOSTNAMEand guards leases whose offset or sequence number isNone.git diff --checkpassed.This is a documentation-only correction to the v1-to-v5 migration sample; it changes no public API and requires no Azure-resource integration test or service credentials.
Disclosure and authorization
Slai Agent Runtime performed the investigation, implementation, and test execution. The account owner authorized this contribution and is responsible for its content.