Skip to content

fix(webui): align Extensions toasts with shared snackbar #6070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stablegenius49 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(webui): align Extensions toasts with shared snackbar #6070

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 0 additions & 12 deletions dashboard/src/views/ExtensionPage.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ const {
extension_data,
getInitialShowReserved,
showReserved,
snack_message,
snack_show,
snack_success,
configDialog,
extension_config,
pluginMarketData,
Expand Down Expand Up @@ -391,15 +388,6 @@ const {
</v-card>
</v-dialog>

<v-snackbar
:timeout="2000"
elevation="24"
:color="snack_success"
v-model="snack_show"
>
{{ snack_message }}
</v-snackbar>

<ReadmeDialog
v-model:show="readmeDialog.show"
:plugin-name="readmeDialog.pluginName"
Expand Down
14 changes: 2 additions & 12 deletions dashboard/src/views/extension/useExtensionPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { useCommonStore } from "@/stores/common";
import { useI18n, useModuleI18n } from "@/i18n/composables";
import { getPlatformDisplayName } from "@/utils/platformUtils";
import { resolveErrorMessage } from "@/utils/errorUtils";
import { useToast } from "@/utils/toast";
import {
buildSearchQuery,
matchesPluginSearch,
Expand Down Expand Up @@ -65,6 +66,7 @@ export const useExtensionPage = () => {
const commonStore = useCommonStore();
const { t } = useI18n();
const { tm } = useModuleI18n("features/extension");
const { toast } = useToast();
const router = useRouter();
const route = useRoute();
const { width } = useDisplay();
Expand Down Expand Up @@ -132,9 +134,6 @@ export const useExtensionPage = () => {
return false;
};
const showReserved = ref(getInitialShowReserved());
const snack_message = ref("");
const snack_show = ref(false);
const snack_success = ref("success");
const configDialog = ref(false);
const extension_config = reactive({
metadata: {},
Expand Down Expand Up @@ -546,12 +545,6 @@ export const useExtensionPage = () => {
}
};

const toast = (message, success) => {
snack_message.value = message;
snack_show.value = true;
snack_success.value = success;
};

const resetLoadingDialog = () => {
loadingDialog.show = false;
loadingDialog.title = tm("dialogs.loading.title");
Expand Down Expand Up @@ -1569,9 +1562,6 @@ export const useExtensionPage = () => {
extension_data,
getInitialShowReserved,
showReserved,
snack_message,
snack_show,
snack_success,
configDialog,
extension_config,
pluginMarketData,
Expand Down