fix(webui): align Extensions toasts with shared snackbar#6070
fix(webui): align Extensions toasts with shared snackbar#6070stablegenius49 wants to merge 1 commit intoAstrBotDevs:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the toast notification system within the Extensions page to align with the global application-level snackbar. By removing the page-specific snackbar implementation and integrating the shared Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
嗨,我已经审阅了你的更改,一切看起来都很棒!
帮我变得更有用吧!请在每条评论上点 👍 或 👎,我会根据你的反馈改进后续的评审。
Original comment in English
Hey - I've reviewed your changes and they look great!
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Code Review
This pull request addresses a UI inconsistency by refactoring the toast notifications on the Extensions page. The local snackbar implementation in ExtensionPage.vue and its state management in useExtensionPage.js have been removed. In their place, the shared useToast composable is now used, which aligns the page's notifications with the rest of the application. The changes are concise and effectively migrate the functionality to the shared system, which should resolve the reported alignment issue.
Fixes #6022.
Modifications / 改动点
useToast()helper so dialog-related toasts render through the same global snackbar as the rest of the dashboardScreenshots or Test Results / 运行截图或测试结果
dashboard/src/views/extension/useExtensionPage.jsdashboard/src/views/ExtensionPage.vue@vue/compiler-sfcChecklist / 检查清单
requirements.txt和pyproject.toml文件相应位置。/ I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations inrequirements.txtandpyproject.toml.Summary by Sourcery
将扩展(Extensions)页面的 toast 处理方式与应用级共享 snackbar 系统对齐。
Bug 修复:
功能增强:
useToast()辅助函数,实现统一的 toast 处理。Original summary in English
Summary by Sourcery
Align the Extensions page toast handling with the shared app-level snackbar system.
Bug Fixes:
Enhancements: