Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest verification
Head cf2b70a passed all six existing Linux/macOS/Windows × Python 3.11/3.12 CI jobs. The first run exposed a separate equal-timestamp feed-list test assumption; corrected membership assertion plus a deterministic timestamp/ID-order regression now cover it. 212 tests passed locally. Earlier validation below is historical.
Scope
Fix two Windows CI failures in binary-discovery tests. Emulate only the module's os.name/environ boundary with a SimpleNamespace; retain the host's native pathlib implementation. No global os.name mutation, platform skips or production behavior changes.
Validation
Linux Python 3.12: all 211 tests passed with inherited HTTP/SOCKS proxy variables removed for the hermetic fake-only test suite; targeted Ruff check passed. Initial inherited-proxy run failed five unrelated tests because socksio is not installed; application proxy policy is unchanged.
Windows and macOS validation await the existing six-job PR CI matrix. Previous failing main run: https://github.com/ArietidsZ/Video-RSS-Aggregator/actions/runs/34218298942 . No model downloads, inference, deployment or merge.