Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1 so the cross-platform fixture repairs stay separate. This PR changes only the fetcher and its tests.
Disable automatic HTTP redirects. Validate scheme/host/resolved addresses before every request; allow at most five redirects; reject missing Location/empty DNS results. Preserve relative redirects, conditional GET/304 and explicit allow_private mode.
Validation: full 218-test suite and Ruff passed locally, using MockTransport for redirects and no real network/model calls. Added public-to-loopback/private/link-local/unsupported-scheme rejection, relative 304 flow and loop bound. The old implementation fails redirect regression cases.
This closes unchecked redirect destinations, NOT DNS rebinding: validation and socket DNS resolution remain separate. Source-media downloader behavior is unchanged. No deployment or merge.