Skip to content

[PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity - #18710

Closed
eishahranipinstech-spec wants to merge 5 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-pt-spectra
Closed

eishahranipinstech-spec wants to merge 5 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-pt-spectra

Conversation

@eishahranipinstech-spec

Copy link
Copy Markdown

The FT0 module-based truth flattenicity compared with the reco flattenicity
The pT-vs-flattenicity histograms at gen and reco level, which are used to make the 0–1% class spectra and ratio plots
The Pearson correlation shown in the truth-vs-reco histogram titles
That it replaces the earlier version of flattenicityTask.cxx

@github-actions

github-actions Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 10 warnings, 🔕 0 disabled

@eishahranipinstech-spec eishahranipinstech-spec changed the title [PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity [PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity Nov 12, 2026
@github-actions github-actions Bot changed the title [PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity [PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity Nov 12, 2026
@vkucera

vkucera commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@eishahranipinstech-spec Who are you?

@eishahranipinstech-spec

Copy link
Copy Markdown
Author

@eishahranipinstech-spec Who are you?

I am a Student, pursuing Masters in Physics , currently in my research phase.
Thanks

@vkucera

vkucera commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@eishahranipinstech-spec Who are you?

I am a Student, pursuing Masters in Physics , currently in my research phase. Thanks

Can you please add your full name on your GitHub profile? It is not easy to decipher it from your username.

@eishahranipinstech-spec

Copy link
Copy Markdown
Author

@eishahranipinstech-spec Who are you?

I am a Student, pursuing Masters in Physics , currently in my research phase. Thanks

Can you please add your full name on your GitHub profile? It is not easy to decipher it from your username.

Done.

@vkucera

vkucera commented Nov 12, 2026

Copy link
Copy Markdown
Collaborator

@eishahranipinstech-spec Who are you?

I am a Student, pursuing Masters in Physics , currently in my research phase. Thanks

Can you please add your full name on your GitHub profile? It is not easy to decipher it from your username.

Done.

Thanks!

@eishahranipinstech-spec

Copy link
Copy Markdown
Author

@aortizve Hi, here is the code for your review of this PR. Thanks

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 542e42b at 2026-11-13 15:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 8 errors and 77 warnings.'
Found 8 errors and 77 warnings.
++ [[ 8 -gt 0 ]]
++ cat /sw/BUILD/e69ea160b4ac4871dc54a39c17b56e7b038cf42d/O2Physics-code-check/errors.txt
PWGMM/UE/Tasks/flattenicityTask.cxx:17:1: error: included header inelGt.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:20:1: error: included header RecoDecay.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:27:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:38:1: error: included header TH1.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:43:1: error: included header algorithm is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:65:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:410:39: error: no header providing "uint8_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGMM/UE/Tasks/flattenicityTask.cxx:472:49: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 77 -gt 0 ]]
++ cat /sw/BUILD/e69ea160b4ac4871dc54a39c17b56e7b038cf42d/O2Physics-code-check/warnings.txt
PWGMM/UE/Tasks/flattenicityTask.cxx:117:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:118:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:119:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:120:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:129:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:130:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:185:20: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGMM/UE/Tasks/flattenicityTask.cxx:185:46: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:185:63: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:185:79: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:185:95: warning: use designated initializer list to initialize 'PtSegment' [modernize-use-designated-initializers]
PWGMM/UE/Tasks/flattenicityTask.cxx:287:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:289:57: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:298:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:300:23: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:303:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:317:20: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:326:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:332:40: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:357:28: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:376:114: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:396:112: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:455:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:457:43: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:461:68: warning: statement should be inside braces [readability-braces-around-statements]
PWGMM/UE/Tasks/flattenicityTask.cxx:463:82: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants