Skip to content

[Infrastructure,PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity - #18736

Closed
eishahranipinstech-spec wants to merge 24 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-pt-spectra
Closed

[Infrastructure,PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity#18736
eishahranipinstech-spec wants to merge 24 commits into
AliceO2Group:masterfrom
eishahranipinstech-spec:flattenicity-pt-spectra

Conversation

@eishahranipinstech-spec

@eishahranipinstech-spec eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Nov 13, 2026 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 12 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Nov 13, 2026
Closed
@alibuild alibuild mentioned this pull request Nov 13, 2026
Closed
@eishahranipinstech-spec eishahranipinstech-spec changed the title [PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity [Infrastructure,PWGLF,PWGMM] Rework flattenicity task: MC truth vs reco, FT0 module geometry, pT vs flattenicity Nov 13, 2026
@alibuild alibuild mentioned this pull request Nov 13, 2026
Merged
@alibuild alibuild mentioned this pull request Nov 13, 2026
Merged
@alibuild alibuild mentioned this pull request Nov 13, 2026
Merged
eishahranipinstech-spec added a commit to eishahranipinstech-spec/O2Physics that referenced this pull request Nov 13, 2026
@eishahranipinstech-spec
Merge pull request #8 from alibuild/alibot-cleanup-18736
c70efa2 
Please consider the following formatting changes to AliceO2Group#18736
@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

@omvazque Hi, can you please merge my code. Thanks

@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

@mpuccio Hi, can you please merge my code. Thanks

vkucera
vkucera requested changes Nov 13, 2026
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eishahranipinstech-spec You are not supposed to touch the CPPLINT.cfg file nor create other versions in other directories. Please remove all those changes from your PR.

@vkucera
vkucera marked this pull request as draft November 13, 2026 21:15
@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

@eishahranipinstech-spec You are not supposed to touch the CPPLINT.cfg file nor create other versions in other directories. Please remove all those changes from your PR.

@vkucera My apologies for that. I have completely removed the CPPLINT.cfg file from the branch history. The PR now only contains the changes to flattenicityTask.cxx. Thank you for catching this.

@eishahranipinstech-spec
eishahranipinstech-spec marked this pull request as ready for review November 13, 2026 21:25
@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

@vkucera Could you please dismiss your requested changes if the PR looks clean to you? The only failing check left is MegaLinter / cpplint, which is flagging O2Physics's standard style (braces, includes) and conflicts with the repo's own clang-format. Thank you!

@vkucera

vkucera commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

@vkucera Could you please dismiss your requested changes if the PR looks clean to you? The only failing check left is MegaLinter / cpplint, which is flagging O2Physics's standard style (braces, includes) and conflicts with the repo's own clang-format. Thank you!

Nothing has changed.

@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

@vkucera Could you please dismiss your requested changes if the PR looks clean to you? The only failing check left is MegaLinter / cpplint, which is flagging O2Physics's standard style (braces, includes) and conflicts with the repo's own clang-format. Thank you!

Nothing has changed.

@vkucera The CPPLINT.cfg and any unrelated files have been completely removed from the branch history. The PR now only contains the changes to flattenicityTask.cxx
or if you are finding any changes, can you let me know please, thanks

@vkucera

vkucera commented Nov 13, 2026

Copy link
Copy Markdown
Collaborator

@vkucera Could you please dismiss your requested changes if the PR looks clean to you? The only failing check left is MegaLinter / cpplint, which is flagging O2Physics's standard style (braces, includes) and conflicts with the repo's own clang-format. Thank you!

Nothing has changed.

@vkucera The CPPLINT.cfg and any unrelated files have been completely removed from the branch history. The PR now only contains the changes to flattenicityTask.cxx or if you are finding any changes, can you let me know please, thanks

As I said, you have made zero changes since I asked you to fix your changes. Please do not mark the PR as ready review until it's fixed.

@vkucera
vkucera marked this pull request as draft November 13, 2026 21:46
@alibuild alibuild mentioned this pull request Nov 13, 2026
Closed
@eishahranipinstech-spec

eishahranipinstech-spec commented Nov 13, 2026

Copy link
Copy Markdown
Author

Closing this due to corrupted git history from a bad merge.Opened a fresh, clean PR (#18744) instead.

@vkucera

vkucera commented Nov 14, 2026

Copy link
Copy Markdown
Collaborator

@eishahranipinstech-spec A bad merge does not corrupt git history. Please learn Git basics and stop replacing your PRs with new ones. It does not solve the problem, as explicitly written in the contribution guidelines. https://aliceo2group.github.io/analysis-framework/docs/gettingstarted/contributingtocode.html#pull-requests

@eishahranipinstech-spec
eishahranipinstech-spec deleted the flattenicity-pt-spectra branch November 14, 2026 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@aalkin aalkin Awaiting requested review from aalkin aalkin is a code owner
@aortizve aortizve Awaiting requested review from aortizve aortizve is a code owner
@jgcn jgcn Awaiting requested review from jgcn jgcn is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@vkucera vkucera Awaiting requested review from vkucera

Assignees

No one assigned

Labels

infrastructure pwglf pwgmm

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eishahranipinstech-spec @vkucera @alibuild