Skip to content

Replacing BaseMM_PRISM with PRISM - #7

Merged
pemami4911 merged 4 commits into
mainfrom
fix-readme
Oct 14, 2026
Merged

pemami4911 merged 4 commits into
mainfrom
fix-readme

Conversation

@pemami4911

Copy link
Copy Markdown
Contributor

Description

Replacing the string BaseMM_PRISM with the updated name PRISM throughout the code base. This doesn't touch the majority of hard coded paths on Aurora in scripts/application-specific code.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that changes existing behavior)
  • Documentation update
  • Infrastructure, CI, or tooling

Compatibility

PRISM has downstream users running long jobs on HPC systems. Does this PR
change any of the following?

  • src.* import paths
  • the prism CLI surface
  • Hydra config keys
  • checkpoint keys
  • launcher flags
  • None of the above

@pemami4911
pemami4911 requested a review from a team as a code owner October 14, 2026 17:09
Sande33p
Sande33p previously approved these changes Oct 14, 2026

@Sande33p Sande33p left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

- launch_aurora.py: default PRISM_DIR falls back to the launcher's own
  checkout (as launch_polaris.py does) instead of a hardcoded user path
  under BaseMM_PRISM.
- aurora_operations.md: replace a real user's checkout path with a
  <project>/<user> placeholder.
- test_scits_fix_static.py: docstring tokenizer path matches the renamed
  model configs.
- launch_polaris.py: comment rename; running_on_polaris.md: realign the
  layout comment column.
- Regenerate the site-path allowlist (two hardcoded paths removed).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@jdwillard19 jdwillard19 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pemami4911
pemami4911 merged commit 4952c36 into main Oct 14, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants