Repository navigation
Rename follow-ups for #7: launcher default, placeholders, docstring - #8
Closed
jdwillard19 wants to merge 1 commit into
Closed
jdwillard19 wants to merge 1 commit into
jdwillard19 wants to merge 1 commit into
Conversation
- launch_aurora.py: default PRISM_DIR falls back to the launcher's own checkout (as launch_polaris.py does) instead of a hardcoded user path under BaseMM_PRISM. - aurora_operations.md: replace a real user's checkout path with a <project>/<user> placeholder. - test_scits_fix_static.py: docstring tokenizer path matches the renamed model configs. - launch_polaris.py: comment rename; running_on_polaris.md: realign the layout comment column. - Regenerate the site-path allowlist (two hardcoded paths removed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #7, targeting its
fix-readmebranch. Covers theBaseMM_PRISMreferences #7 left that are user-facing rather than personal Aurora script paths:tools/launch_aurora.py— thePRISM_DIRfallback was/flare/ModCon/ngetty/BaseMM_PRISM, so anyone running without a.envgot another user's checkout. It now falls back to the repo the launcher lives in, the same logictools/launch_polaris.pyalready uses.docs/platforms/aurora_operations.md—cd /lus/flare/projects/ModCon/ngetty/PRISM(a renamed path that doesn't exist) becomes<project>/<user>/PRISM.tests/test_scits_fix_static.py— docstring tokenizer path now matches the model configs renamed in Replacing BaseMM_PRISM with PRISM #7.tools/launch_polaris.pycomment rename;docs/platforms/running_on_polaris.mdlayout comment realigned after the shorter name.tools/ci/site_path_allowlist.json— regenerated withcheck_site_paths.py --write; the two removed hardcoded paths tripped the ratchet.Left intentionally: per-user Aurora script/experiment paths (
tools/*.sh,tools/isoflop_*.py,experiments/*.yaml),NOTICE(points at a real BaseMM_PRISM issue),tests/test_site_path_gate.py(detector test input), andtools/make_release_snapshot.sh.Type of Change
Compatibility
src.*import pathsprismCLI surfaceThe launcher's default
PRISM_DIRchanges only when.envhas noPRISM_DIR; no flags change.Testing
ruff checkclean;tests/test_scits_fix_static.py,test_site_path_gate.py,test_site_paths.py,test_docs_consistency.py,test_launch_unified.py,test_launch_common.py— 83 passed locally.🤖 Generated with Claude Code