Fix:Improve error handling when a request fails due to the persistent connection being expired #761#854
Conversation
Enhanced the do_api_query function with a retry mechanism (up to 3 attempts) for transient connection errors, configurable retry delays, and keep-alive headers. It resets the HTTP session on failures, differentiates between network errors and API errors, and maintains backward compatibility while improving reliability with optimized timeouts (90s for long-polling, 15s default).
Added missing whitespace for better readability and fixed minor typos in help_message and alert_move_message. Improved assertions and refactored redundant checks for cleaner test logic.
|
Hello @avijitdas126, it seems like you have referenced #761 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit: To learn how to write a great commit message, please refer to our guide. |
1 similar comment
|
Hello @avijitdas126, it seems like you have referenced #761 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit: To learn how to write a great commit message, please refer to our guide. |
Added missing whitespace for better readability and fixed minor typos in help_message and alert_move_message. Improved assertions and refactored redundant checks for cleaner test logic.
95f88af to
078a153
Compare
|
@timabbott could you please review this PR? |
Enhanced the do_api_query function with a retry mechanism (up to 3 attempts) for transient connection errors, configurable retry delays, and keep-alive headers. It resets the HTTP session on failures, differentiates between network errors and API errors, and maintains backward compatibility while improving reliability with optimized timeouts (90s for long-polling, 15s default).
Fixes: #761
How did you test this PR?
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: