api: Implement GET /messages/{message_id}/read_receipts endpoint#821
Open
codewithnick wants to merge 1 commit intozulip:mainfrom
Open
api: Implement GET /messages/{message_id}/read_receipts endpoint#821codewithnick wants to merge 1 commit intozulip:mainfrom
codewithnick wants to merge 1 commit intozulip:mainfrom
Conversation
codewithnick
force-pushed
the
get_message_read_recipt
branch
from
52fcb3a to
2992ba1
Compare
Member
|
Please fix the typos in the function name -- these should all match the URLs in the API documentation. Check out the Zulip commit message guidelines for more details. |
codewithnick
force-pushed
the
get_message_read_recipt
branch
from
2992ba1 to
c94f208
Compare
codewithnick
changed the title
Author
Author
|
hi any updates on this @timabbott |
timabbott
reviewed
Jun 6, 2024
| return self.call_endpoint( | ||
| url=f"messages/{message_id}/read_receipts", | ||
| method="GET", | ||
| ) |
Member
There was a problem hiding this comment.
Our usual convention is to use the same names as the URL suffices on https://zulip.com/api/get-read-receipts.
Author
There was a problem hiding this comment.
so should I change the function name to get_read_receipts, not sure if that is what you meant
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a local function for getting a messages read recipt
reference https://zulip.com/api/get-read-receipts
proof of working: