chore: address PR #414/#415 review feedback #417
+114
−89
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,52 +1,68 @@ | ||
| import '../unit/vscode_mock_setup'; | ||
| import { createNativeDatabaseConnection } from '../../src/nativeWorker'; | ||
| import type { ModificationEntry } from '../../src/core/types'; | ||
| import * as vscode from 'vscode'; | ||
| import * as path from 'path'; | ||
| import * as fs from 'fs/promises'; | ||
|
|
||
| async function runBenchmark() { | ||
| const bundle = await createNativeDatabaseConnection(vscode.Uri.file(process.cwd())); | ||
| // The native API opens a file URI, so the benchmark uses a unique local database and removes it after disposal. | ||
| const databasePath = path.join(process.cwd(), `native_worker_ddl_batch_${process.pid}_${Date.now()}.sqlite`); | ||
|
|
||
| try { | ||
| const { databaseOps: db } = await bundle.establishConnection( | ||
| vscode.Uri.file(databasePath), | ||
| path.basename(databasePath) | ||
| ); | ||
|
|
||
| // create table | ||
| await db.createTable('test_table', [ | ||
| { name: 'id', type: 'INTEGER', primaryKey: true, notNull: false }, | ||
| ...Array.from({ length: 50 }, (_, i) => ({ | ||
| name: `col_${i}`, | ||
| type: 'TEXT', | ||
| primaryKey: false, | ||
| notNull: false | ||
| })) | ||
| ]); | ||
|
|
||
| // insert row | ||
| await db.insertRow('test_table', { | ||
| id: 1, | ||
| ...Object.fromEntries(Array.from({ length: 50 }, (_, i) => [`col_${i}`, `val_${i}`])) | ||
| }); | ||
|
|
||
| const mod = { | ||
| description: 'Drop benchmark columns', | ||
| modificationType: 'column_drop' as const, | ||
| targetTable: 'test_table', | ||
| deletedColumns: Array.from({ length: 50 }, (_, i) => ({ | ||
| name: `col_${i}`, | ||
| type: 'TEXT', | ||
| data: [{ rowId: 1, value: `val_${i}` }] | ||
| })) | ||
| } satisfies ModificationEntry; | ||
|
|
||
| console.log('Warming up...'); | ||
|
|
||
| // warmup | ||
| await db.undoModification(mod); | ||
| await db.redoModification(mod); | ||
|
|
||
| console.log('Running benchmark...'); | ||
|
|
||
| const start = performance.now(); | ||
| for (let i = 0; i < 5; i++) { | ||
| await db.undoModification(mod); | ||
| await db.redoModification(mod); | ||
| } | ||
| const end = performance.now(); | ||
| console.log(`Time taken: ${(end - start).toFixed(2)}ms`); | ||
| } finally { | ||
| bundle.workerMethods[Symbol.dispose](); | ||
| await fs.rm(databasePath, { force: true }); | ||
| } | ||
| } | ||
|
|
||
| runBenchmark().catch(console.error); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a potential race condition when deleting the database file immediately after calling
bundle.workerMethods[Symbol.dispose]().The
Symbol.disposecall triggersworker.stop(), which asynchronously kills the child process (this.process.kill()). Since process termination and file descriptor release by the OS are asynchronous,fs.rmmight execute while the file is still locked by the terminating process (especially on Windows). This can cause the benchmark to fail withEBUSYorEPERMerrors.To make this robust, we can implement a simple retry loop with a small delay to ensure the file is successfully deleted once the lock is released.