feat: FTS: add OSS OpenSearch backend, semantic FTS recall, filtered FTS cases - #815
feat: FTS: add OSS OpenSearch backend, semantic FTS recall, filtered FTS cases#815jamesgao-jpg wants to merge 46 commits into
Conversation
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Remove filtered FTS dataset, runner, backend, frontend, test, and published result changes while retaining unfiltered OSS OpenSearch and semantic FTS support. Remove the task-local session progress file from the branch. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Preserve current upstream backends and compatibility changes while retaining the unfiltered FTS and OSS OpenSearch work from fts_ver2. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jamesgao-jpg The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Restore the filtered full-text search cases, datasets, runners, backend clients, CLI controls, and regression tests removed by 7cd3046. Keep frontend support, generated result artifacts, session files, and documentation excluded from this backend migration. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Apply current Black formatting to the restored filtered-FTS code, use direct integer filter attribute access, and document the intentional runtime error inside the serial-search exception boundary. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Assign FTS filter IDs through a versioned affine permutation so threshold filters preserve exact cardinality while spreading matches across corpus insertion order. Use the same mapping for semantic qrels and record its parameters in filter statistics for reproducibility. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Expose sequential and permuted FTS filter-ID distributions through the common CLI and FTS case configuration, defaulting to the deterministic permutation. Propagate the selected mode into document insertion, semantic qrel filtering, and versioned result metadata. Changing modes requires reloading the target collection. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Preserve filtered FTS backend and CLI support while incorporating the finalized common note validation and thread-safe Hologres client. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Remove the published Vespa FTS result while preserving its backend. Restore the Zilliz Cloud filtered semantic result and keep filtered rows out of the standard FTS frontend. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Publish validated permuted concurrency results for Elasticsearch, OSS OpenSearch, and Zilliz Cloud. Add a Filtered QPS frontend view and remove the legacy sequential Zilliz artifact. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Add ten permuted filtered FTS result artifacts for HotpotQA Large and MS MARCO Large across five filter rates. Extend the frontend coverage test to include Turbopuffer. The benchmark observed service-side 429 responses at some concurrency points; recorded QPS is successful request throughput. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Merge validated serial latency and semantic metrics into the existing filtered concurrent result artifacts while preserving source provenance. Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
XuanYang-cn
left a comment
There was a problem hiding this comment.
Requesting changes for the standards/maintainability issue below. Reviewed at 1b0a0bb97904fa259c3c0d350a394022d39383cd.
- The filtered-FTS document-to-filter-ID mapping has two independent implementations.
FtsDatasetManager._build_qrel_filter_ids()replays the corpus and derives IDs fromselected_doc_ids,emitted_count, andFtsFilterIdPermutation, whileFtsDocumentIterator.__next__()separately derives the IDs used for inserted documents. These paths already differ in error handling: the iterator skips malformed documents, but the qrel mapping loop does not. Any future drift in selection, skipping, or ordering can make the filter IDs used to prune qrels disagree with the IDs stored in the backend, silently producing invalid filtered recall. Please make filter-ID assignment a single shared primitive used by both paths, and add a regression test proving qrel IDs equal emitted document IDs when documents are skipped or the selected set is sparse.
Lower-severity cleanup:
MilvusConfig(...)construction is repeated across 18 CLI commands invectordb_bench/backend/clients/milvus/cli.py. A shared builder/helper would prevent command-specific defaults from drifting.OSSOpenSearchFtsConfigduplicates the FTS text mapping and BM25 similarity construction fromElasticCloudFtsConfig. Please consider extracting the shared mapping/settings logic so the two Elasticsearch-compatible backends stay aligned.
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
I addressed the primary issue and both lower-severity cleanup items in separate commits:
All three commits include the required DCO sign-off. Please take another look when convenient. |
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Signed-off-by: jamesgao-jpg <james.gao@zilliz.com>
Summary
This PR adds OSS OpenSearch and the backend support needed for both unfiltered and filtered full-text search benchmarking. It also publishes validated permuted filtered-concurrency results for Elasticsearch, OSS OpenSearch, Zilliz Cloud, and Turbopuffer, with a dedicated
Filtered QPSfrontend view. The frontend keeps filtered results in a dedicated view, while each backend's standard and filtered records are consolidated into one published JSON artifact.PR #794 introduced the preceding full-text search benchmark foundation used by this work. This PR supersedes #814 with a reduced publication scope. PR #818 introduces shared CLI run-context notes; its commit is incorporated here so FTS results preserve deployment and constraint context.
Changes
--fts-filter-ratecontrolfilter_idvalues with a deterministic bijection so exact-selectivity filters are scattered across corpus insertion order rather than selecting a contiguous suffixFiltered QPSfrontend tab with dataset and backend filters0.50,0.75,0.90,0.95, and0.99; refreshed Zilliz Cloud records use concurrency40,60, and80, while the other backends retain60and80--noteand--note-fileCLI options while preserving Pinecone compatibilitymainResult Provenance
The Elasticsearch and OSS OpenSearch filtered results come from the approved 2026-07-16 total-series benchmark executed with VDBBench commit
e24110b(feat(fts): make filter id distribution configurable). The Turbopuffer results come from the completed 2026-08-02 run executed with commit07bcefd(feat: publish permuted filtered FTS results). The 16 Zilliz Cloud records were refreshed from the approved 2026-08-07 Task 15919 series executed from clean detached commit078d524and published in commit0e17679.Elasticsearch, OSS OpenSearch, and Turbopuffer retain serial P95/P99, recall, NDCG, and MRR composed from their approved serial runs; those records carry
additional_parameters.serial_measurementwith source provenance. The refreshed Zilliz Cloud records measured serial and concurrent search directly in the same run and therefore do not require composed-source provenance.The ten Turbopuffer records preserve the measured result content with only
db_config.api_keycleared before publication. All 40 filtered records were validated for:custom_case.filter_id_distribution = "permuted"; refreshed Zilliz Cloud records omit the removed selectoradditional_parameters.fts_filter.filter_id_distribution = "affine_permutation_v1"[60, 80]for historical records and[40, 60, 80]for refreshed Zilliz Cloud recordsThe standard and filtered records remain consolidated into one JSON per backend. The refreshed bundle contains 76 entries: 36 standard and 40 filtered. For Zilliz Cloud, source comparison confirmed that all 16 measured records remained unchanged except for the documented
db_config.noteevidence text.The concurrent measurements use 30 seconds per concurrency level,
k=100, and IDs-only payloads. OpenSearch and Elasticsearch ran as isolated single-node Docker deployments. Refreshed Zilliz Cloud results used Task 15919 with an 8 CU performance instance, one replica, and one persistent segment per benchmark collection; small and medium datasets used insert batch size 1,000 and load concurrency 4, while the large datasets reused validated loaded collections for search-only runs. Turbopuffer used the managed service inaws-us-west-2.Turbopuffer Run Caveat
The Turbopuffer run observed service-side HTTP 429 responses at several concurrency points, including 63 responses for HotpotQA Large at 50% matched documents. The published QPS values count successful request throughput under that service limit; they should not be interpreted as an error-free saturation curve.
Deferred Scope
Compatibility
FTS collections loaded before commit
bf85cf7contain legacyfilter_idvalues. Reload those collections before running filtered FTS search so stored IDs and semantic qrel filtering use the same affine permutation.Verification
659f739, followed by isolated current-lint compatibility commita352b73bf85cf7New Zilliz Cloud and Turbopuffer provider runs are included in this update; Elasticsearch and OSS OpenSearch continue to use the previously validated total-series evidence.