Repository navigation
feat: Add optional task queue prop to RunWorkflow - #25
Merged
Merged
Conversation
SGunner2014
force-pushed
the
feat/run-workflow-task-queue
branch
2 times, most recently
from
October 30, 2026 10:53
4a61e98 to
a95df53
Compare
Signed-off-by: Sam Gunner <me@sgunner.me>
SGunner2014
force-pushed
the
feat/run-workflow-task-queue
branch
from
October 30, 2026 10:59
ec62af9 to
2684ccb
Compare
SGunner2014
marked this pull request as ready for review
October 30, 2026 11:16
YJ-928
approved these changes
Nov 2, 2026
Member
There was a problem hiding this comment.
Thanks @SGunner2014, this looks good: optional, additive, and named like the other run.workflow fields, and CI is green. Approving.
Two small things, neither blocking:
64-character name is acceptedreads as if there were a 64-character limit, but the schema sets no maximum. I'd drop that case or rename it.- The commit shows as unverified on GitHub (
unknown_key). It doesn't block this repo, but zigflow/zigflow requires verified signatures, so add the signing key to your GitHub account before the runtime PR.
For the follow-up runtime PR in zigflow/zigflow (nothing to change here):
- Say whether
taskQueueis a plain string or can be a runtime expression (${ ... }). If expressions are allowed, it needs to be evaluated before the child starts, plus a test. - Nothing can check that a worker polls that queue, so the child would sit pending. A line in the
run.workflowdocs saying a worker must listen on that queue would save people a confusing wait.
I'll merge in a day or two so you can fold in the first point if you want; it's fine as is otherwise.
Signed-off-by: Sam Gunner <me@sgunner.me>
Contributor
Author
|
@YJ-928 Thanks, makes sense. I've updated the PR to remove this test case and have added a signing key for future changes. |
Member
|
Thanks @SGunner2014, all good. Merging. Looking forward to the runtime PR in zigflow/zigflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds an optional
taskQueueproperty to therun.workflowschema. If defined, then the new workflow will run on the task queue specified. Otherwise, it will default to the parent's task queue as is the current behaviour.This PR updates the schema validation only, runtime support will be handled separately.
Related issue
Relates to zigflow/zigflow#556
How to test
Run the focused schema tests:
Start a workflow with a
workflowstep configured with a customtaskQueue:The child workflow should then be triggered on the task queue
orders.v2.Checklist
Fixes #...,Closes #...orRelates to #...