add blocking parameter to get_gamepad method (fix #7)#9
Open
Fuzzyma wants to merge 1 commit intozeth:masterfrom
Open
add blocking parameter to get_gamepad method (fix #7)#9Fuzzyma wants to merge 1 commit intozeth:masterfrom
get_gamepad method (fix #7)#9Fuzzyma wants to merge 1 commit intozeth:masterfrom
Conversation
Jonniewanathan
added a commit
to Jonniewanathan/inputs
that referenced
this pull request
Feb 19, 2019
this code has been taken from the an issue on the the original repository: zeth#9
orangedude27
approved these changes
Jul 14, 2019
|
This works on Windows, however for Linux (rasberry pi) the read() command still blocks. I have tracked down the function that blocks, which is the _get_data(self, read_size) function, when it performs self._character_device.read(read_size). When running on linux the _character_device returns a BufferedReader object, from using the io.open(path, 'rb') command. When running on windows it uses a simpler approach with io.BytesIO() which I guess does not block? def _character_device(self):
if not self._character_file:
if WIN:
self._character_file = io.BytesIO()
return self._character_file
try:
self._character_file = io.open(
self._character_device_path, 'rb')
except IOError as err:
...
return self._character_fileI am trying to implement this on a Rasberry Pi, thus I need this to work. Anyone got any ideas of how to implement this differently? |
|
Thank You.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #7 the get_gamepad method blocks further execution of the program which is often not desired.
This PR intends to add a
blockingparameter which can be used to disable this behavior.You now can do something like this:
Note the array index
[0]I have to use because it always returns only one array element.I dont know the internals of other devices or other systems. So I leave it as it is. However: For xbox one controller with win7 this could be simplified (see #8)