Skip to content

chore: raise the minimum supported Node.js version to 22 - #2898

Open
Shriraj1901 wants to merge 1 commit into
zenstackhq:devfrom
Shriraj1901:chore/min-node-22
Open

Shriraj1901 wants to merge 1 commit into
zenstackhq:devfrom
Shriraj1901:chore/min-node-22

Conversation

@Shriraj1901

@Shriraj1901 Shriraj1901 commented Oct 29, 2026 •

Copy link
Copy Markdown

kysely 0.29 and chevrotain 12 (via langium) both require Node.js >= 22. Declare ">=22" in the engines field of the cli, orm and language packages and add Node.js 22.x to the build-test matrix so that the minimum supported version is tested.

Summary by CodeRabbit

  • Compatibility
    • The CLI, language, and ORM packages now require Node.js 22 or later. Node.js 20 is no longer supported by the CLI.
  • Chores
    • Build and test workflows now run against Node.js 22 and 24.

kysely 0.29 and chevrotain 12 (via langium) both require Node.js >= 22.
Declare ">=22" in the engines field of the cli, orm and language packages
and add Node.js 22.x to the build-test matrix so that the minimum
supported version is tested.
@coderabbitai

coderabbitai Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between d44e489 and 838f4b2.

Files selected for processing: 4
  • .github/workflows/build-test.yml
  • packages/cli/package.json
  • packages/language/package.json
  • packages/orm/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The build-and-test workflow now tests Node.js 22.x and 24.x. The CLI, language, and ORM packages declare Node.js 22 or later as their minimum runtime.

Changes: Node.js support

Layer / File(s) Summary
Runtime requirement and validation
.github/workflows/build-test.yml, packages/cli/package.json, packages/language/package.json, packages/orm/package.json
The workflow matrix includes Node.js 22.x alongside 24.x. The three package manifests set the minimum Node.js version to 22.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Possibly related issues

  • Issue 2896 requests a Node.js minimum of 22 due to Kysely and Chevrotain requirements. This pull request updates the package minimums and adds Node.js 22 to the test matrix.

Suggested reviewers: ymc9

Merge Risk: Minimal · up to 838f4

The runtime requirement and CI coverage are aligned; no actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "chore: raise the minimum supported Node.js version to 22" matches the main change. The PR raises the declared minimum Node.js version to 22 in the CLI, ORM, and language packages' engines f…
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "chore: raise the minimum supported Node.js version to 22" matches the main change. The PR raises the declared minimum Node.js version to 22 in the CLI, ORM, and language packages' engines fields, and adds Node.js 22.x to the build-test matrix. The title is specific and concise. It does not mention the matrix change, which is a secondary detail.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant