Skip to content

ci: restore Node 24.x for publish, patch jsonschema URL resolution (#2838) - #2839

Merged
ymc9 merged 1 commit into
mainfrom
dev
Sep 10, 2026
Merged

ci: restore Node 24.x for publish, patch jsonschema URL resolution (#2838)#2839
ymc9 merged 1 commit into
mainfrom
dev

Conversation

@ymc9

@ymc9 ymc9 commented Sep 10, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes

    • Improved resolution of relative references in JSON schemas, helping validation handle linked schemas more reliably.
  • Chores

    • Updated automated build, test, and release processes to use Node.js 24.

@coderabbitai

coderabbitai Bot commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2f931ff7-a457-4863-bace-5a82c6629cb9

📥 Commits

Reviewing files that changed from the base of the PR and between e58e2d4 and 53d0b9c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (4)
  • .github/workflows/build-test.yml
  • .github/workflows/publish-release.yml
  • package.json
  • patches/jsonschema@1.5.0.patch

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PR registers a local patch for jsonschema@1.5.0 and changes schema URL resolution. Both build-test and publish-release workflows update Node.js from 22.x to 24.x.

Changes

Runtime and schema updates

Layer / File(s) Summary
Register and apply the jsonschema URL patch
package.json, patches/jsonschema@1.5.0.patch
pnpm applies a local patch to jsonschema@1.5.0. The patch changes the base URL used by Validator.prototype.resolve.
Run CI workflows on Node.js 24.x
.github/workflows/build-test.yml, .github/workflows/publish-release.yml
The test matrix and release workflow use Node.js 24.x instead of 22.x.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 53d0b

No concrete current-head issue remains that should block merging.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies both primary changes: restoring Node.js 24.x in CI workflows and patching jsonschema URL resolution.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ymc9
ymc9 merged commit b4d5182 into main Sep 10, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant