Skip to content

test(bundler): Make tests path-separator agnostic #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vitallium merged 1 commit into from
Jan 25, 2026
Merged

test(bundler): Make tests path-separator agnostic #237

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions src/bundler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ mod tests {
use super::*;
use crate::command_executor::CommandExecutor;
use std::cell::RefCell;
use std::path::Path;
use zed_extension_api::process::Output;

struct MockExecutorConfig {
Expand Down Expand Up @@ -158,7 +159,10 @@ mod tests {
gem: &str,
) -> MockCommandExecutor {
let mock = MockCommandExecutor::new();
let gemfile_path = format!("{dir}/Gemfile");
let gemfile_path = Path::new(dir)
.join("Gemfile")
.to_string_lossy()
.into_owned();
mock.expect(
"bundle",
&["info", "--version", gem],
Expand Down Expand Up @@ -187,12 +191,15 @@ mod tests {
let mock_executor = MockCommandExecutor::new();
let gem_name = "unknown_gem";
let error_output = "Could not find gem 'unknown_gem'.";
let gemfile_path = "test_dir/Gemfile";
let gemfile_path = Path::new("test_dir")
.join("Gemfile")
.to_string_lossy()
.into_owned();

mock_executor.expect(
"bundle",
&["info", "--version", gem_name],
&[("BUNDLE_GEMFILE", gemfile_path)],
&[("BUNDLE_GEMFILE", &gemfile_path)],
Ok(Output {
status: Some(1),
stdout: Vec::new(),
Expand Down Expand Up @@ -223,12 +230,15 @@ mod tests {
let mock_executor = MockCommandExecutor::new();
let gem_name = "critical_gem";
let specific_error_msg = "Mocked execution failure";
let gemfile_path = "test_dir/Gemfile";
let gemfile_path = Path::new("test_dir")
.join("Gemfile")
.to_string_lossy()
.into_owned();

mock_executor.expect(
"bundle",
&["info", "--version", gem_name],
&[("BUNDLE_GEMFILE", gemfile_path)],
&[("BUNDLE_GEMFILE", &gemfile_path)],
Err(specific_error_msg.to_string()),
);

Expand Down