Repository navigation
fix(zotero): preserve Unicode quote ranges - #102
Draft
Ricardo-M-L wants to merge 1 commit into
Draft
Ricardo-M-L wants to merge 1 commit into
Ricardo-M-L wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin type (required)
Affected plugin name:
zoteroWhat
Fix PDF quote matching and highlight ranges for supplementary-plane mathematical characters and combining sequences. Currently
The equation 𝑥 = 1 follows.does not matchx = 1: NFKC is applied to half of each UTF-16 surrogate pair. The previous end-offset calculation can also truncate the original character.0.1.0to0.1.1, with equivalent English/Chinese documentation.No new dependencies, permissions, network services or changes to write authorization. Tests use isolated fake Zotero data; no real user library was read or modified. No generated distributions are committed.
Verification
x = 1finds the original𝑥 = 1text and maps the complete glyph.find_in_pdf → highlight → save_highlights → resource read-backagainst isolated fake Zotero and a real PDF.git diff --check: passed.Outstanding / draft boundary
This is a draft pending full repository packaging and real ZCode Desktop + Zotero installation verification. Full
pnpm buildstops in the unrelatedphotocraftsnapshot build because the pinned Rust WASM target / Trunk toolchain is missing; consequentlybuild_dist.pyrejects the incomplete build. No build checks were bypassed. No real Zotero application is installed on this test machine, and Desktop installation verification is not claimed.Root
pnpm testpassed in an earlier run. A subsequent run encountered the untouched Typst notification-count timing test (test/tools.test.ts:151, expected at least 4 notifications, received 3); that file passed all 14 tests when rerun independently. The failed full run is not hidden as a successful run.Self-check