Skip to content

fix: resolve AndroidViewComponent cast error on sprite / Ball removal #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gueei wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve AndroidViewComponent cast error on sprite / Ball removal #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions src/com/yusufcihan/DynamicComponents/DynamicComponents.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,11 +321,11 @@ public void Move(AndroidViewComponent arrangement, AndroidViewComponent componen
"so its ID can be reused for other components that are going to be created later."
)
public void Remove(String id) {
Object component = COMPONENTS.get(id);
Component component = COMPONENTS.get(id);
if (component == null) {
return;
}
RemoveComponent((AndroidViewComponent)component);
RemoveComponent(component);
COMPONENTS.remove(id);
COMPONENT_IDS.remove(component);
}
Expand All @@ -335,24 +335,28 @@ public void Remove(String id) {
"But if the given component is dynamically created by this extension, this block will also " +
"de-register its ID so its ID can be reused for other components that are going to be created later."
)
public void RemoveComponent(AndroidViewComponent component) {
public void RemoveComponent(Component component) {
try {
Method mMethod = Utils.getMethod(component, "getView");
if (mMethod != null) {
final View mComponent = (View) mMethod.invoke(component);
final ViewGroup mParent = (ViewGroup) mComponent.getParent();
if (postOnUiThread) {
new Handler(Looper.getMainLooper()).post(new Runnable() {
@Override
public void run() {
if (mComponent != null) {
final ViewGroup mParent = (ViewGroup) mComponent.getParent();
if (mParent != null) {
if (postOnUiThread) {
new Handler(Looper.getMainLooper()).post(new Runnable() {
@Override
public void run() {
mParent.removeView(mComponent);
}
});
} else {
mParent.removeView(mComponent);
}
});
} else {
mParent.removeView(mComponent);
}
}
}
final String[] closeMethods = new String[] { "onPause", "onDestroy" };
final String[] closeMethods = new String[] { "onPause", "onDestroy", "onDelete" };
for (String methodName : closeMethods) {
final Method invokeMethod = Utils.getMethod(component, methodName);
if (invokeMethod != null)
Expand Down