Repository navigation
Conversation
- 공통 및 프로젝트 지침 경로 변경과 원격 작업 규칙 반영 - 관련 이슈: #67 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- DefStream의 공통 지침을 `.instructions.assistant/`로 이동하고 프로젝트별 지침을 보존 - 이슈와 에이전트 브랜치의 PR을 `IR.md`로 갱신하고, 릴리즈 노트에 PR의 `Changes:` 경로를 사용 - CI가 이슈별 변경 로그를 확인하도록 안내 추가 - 관련 이슈: #67
There was a problem hiding this comment.
🟡 Changes recommended
Active moderate and critical findings remain: the script can reject valid PRs at the 3,000-file boundary, and the workflow may expose private credentials and write-scoped tokens to code from modifiable branches.
2 open issues
What changed in this PR
This pull request adds repository-tracked common agent instructions and updates issue/agent-branch PR automation and release-note collection around IR.md and CHANGELOG.md.
Changes:
- Added
AGENTS.mdand.instructions.assistant/guidance while preserving project-specific instructions. - Updated PR creation and synchronization for issue, Copilot, and Codex branches.
- Added
Changes:path handling for release notes and expanded JavaScript/Python test coverage. - Live GitHub Actions execution and permission behavior remain unverified.
This pull request requires changes.
| File | Description |
|---|---|
issues/task/67/tasks/1794072954261.md |
Records follow-up verification results and remaining limitations. |
issues/task/67/tasks/1793888309066.md |
Records initial issue, branch, CI, and instruction investigation. |
issues/task/67/TASKS.md |
Summarizes investigation and verification work. |
issues/task/67/REQUIREMENTS.md |
Defines requirements and acceptance criteria for common guidance and PR automation. |
issues/task/67/README.md |
Records issue scope, status, and task documentation links. |
issues/task/67/PLAN.md |
Records implementation phases and verification status. |
issues/task/67/IR.md |
Provides the PR title, body, validation details, and changelog reference. |
issues/task/67/implements/1794072954261.md |
Records the follow-up instruction and PR automation implementation. |
issues/task/67/implements/1793888309066.md |
Records the initial AGENTS.md and common-guidance implementation. |
issues/task/67/IMPLEMENTS.md |
Summarizes implementation results and related records. |
issues/task/67/context/1794072954261.md |
Records follow-up automation and instruction integration decisions. |
issues/task/67/context/1793888309066.md |
Records the initial instruction-storage decision and constraints. |
issues/task/67/CHANGELOG.md |
Describes the customer-facing automation and instruction changes. |
AGENTS.md |
Provides the repository entry point for common, project-specific, issue, and PR workflow instructions. |
.instructions/README.instructions.md |
Corrects the path to the project documentation instructions. |
.instructions/DOCS.instructions.md |
Defines DefStream documentation and synchronization guidance. |
.instructions/CODE.instructions.md |
Defines English-language policy for code-facing messages and documentation. |
.instructions.assistant/TASK.instructions.md |
Defines task records, PR documents, changelogs, and verification procedures. |
.instructions.assistant/MARKDOWN.instructions.md |
Defines Markdown structure, links, examples, and validation guidance. |
.instructions.assistant/INSTRUCTIONS.instructions.md |
Defines instruction discovery, scope, and conflict handling. |
.instructions.assistant/GIT.COMMIT.MESSAGE.instructions.md |
Defines commit-message writing and trailer guidance. |
.instructions.assistant/DEV.Python.instructions.md |
Provides Python style, typing, documentation, and implementation guidance. |
.instructions.assistant/DEV.Javascript.instructions.md |
Provides JavaScript module, runtime, browser, and asynchronous-code guidance. |
.instructions.assistant/DEV.instructions.md |
Defines shared development, design, and testing principles. |
.github/workflows/create-pr-from-issue.yml |
Triggers PR automation for copilot/** and codex/** branches. |
.github/workflows/ci.yml |
Reads validated Changes: paths from merged PR bodies for release notes. |
.github/scripts/tests/test_release_notes.py |
Tests release-note path selection and changelog validation. |
.github/scripts/tests/create-pr-from-issue.test.mjs |
Tests IR-based PR creation, agent branch handling, validation, and synchronization. |
.github/scripts/create-pr-from-issue.mjs |
Builds PRs from IR.md, validates changelogs, and synchronizes existing agent PRs. |
Review effort: Lite
- CHANGELOG.md가 일반 파일이어야 함을 확인하는 로직 추가 - PR 생성 시 CHANGELOG.md의 형식 검증 강화 - 관련 테스트 케이스 추가 및 기존 테스트 수정 - 문서에서 변경 사항 및 요구 사항 업데이트 - 관련 이슈: #67
There was a problem hiding this comment.
🔵 Needs a closer look
The changes span Actions, GitHub App authentication, PR mutation, and release-note collection, but only mocked local paths were tested, leaving real workflow permissions and end-to-end behavior unverified.
No open issues 🎉
2 resolved since last review
Review effort: Lite


변경 내용
.instructions.assistant/에 적용하고 프로젝트별 지침을 유지합니다.IR.md로 갱신하고, 릴리즈 노트에 PR의Changes:경로를 사용합니다.Changes:마커의 형식과 변경 로그의 일반 파일 여부를 검사합니다.변경 유형
검증
관련 이슈 및 변경 로그