Fix syncedFolder path when projectDirectory differs - #1636
Open
Ckitakishi wants to merge 1 commit into
Open
Conversation
… the project directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When the spec file and the generated project are in different directories, a
syncedFoldersource gets a path relative to the spec directory instead of the project directory. Xcode resolves that path from the xcodeproj location, so it points at a directory that doesn't exist. The synced folder is then silently treated as empty: the target compiles zero files but still reports BUILD SUCCEEDED.The syncedFolder branch computes the relative path from
project.basePath, which is the spec directory. Paths written into the pbxproj need to be relative to the output directory instead. Regular groups already handle this throughresolveGroupPath, which uses thebasePathproperty (projectDirectory ?? project.basePath).Added a regression test that fails without the fix.