Skip to content

Allow symfony/console 8#447

Merged
samdark merged 1 commit intomasterfrom
allow-symfony-8
Feb 22, 2026
Merged

Allow symfony/console 8#447
samdark merged 1 commit intomasterfrom
allow-symfony-8

Conversation

@samdark
Copy link
Member

@samdark samdark commented Feb 22, 2026

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copilot AI review requested due to automatic review settings February 22, 2026 15:55
@codecov
Copy link

codecov bot commented Feb 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.96%. Comparing base (0233f44) to head (c400625).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #447   +/-   ##
=========================================
  Coverage     76.96%   76.96%           
  Complexity       29       29           
=========================================
  Files            11       11           
  Lines           178      178           
=========================================
  Hits            137      137           
  Misses           41       41           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@samdark samdark merged commit baafb50 into master Feb 22, 2026
20 checks passed
@samdark samdark deleted the allow-symfony-8 branch February 22, 2026 15:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the symfony/console dependency constraint to allow version 8 in addition to version 7. This is a maintenance update to support newer versions of Symfony Console while the application continues to use basic console features (command creation, input/output handling) that are stable across these versions.

Changes:

  • Updated symfony/console version constraint from ^7.4.1 to 7 - 8
  • Added CHANGELOG entry documenting this change

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
composer.json Updates symfony/console version constraint to allow version 8
CHANGELOG.md Documents the dependency version update in the 1.2.1 release notes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

"psr/http-server-handler": "^1.0.2",
"psr/log": "^3.0.2",
"symfony/console": "^7.4.1",
"symfony/console": "7 - 8",
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint "7 - 8" will be interpreted by Composer as ">=7.0.0 <9.0", which is broader than the original constraint "^7.4.1" (which was ">=7.4.1 <8.0.0"). This could allow symfony/console 7.0.0 through 7.4.0 to be installed, which were explicitly excluded before. Consider using "^7.4.1 || ^8.0" instead to maintain the minimum version requirement while allowing version 8.

Suggested change
"symfony/console": "7 - 8",
"symfony/console": "^7.4.1 || ^8.0",

Copilot uses AI. Check for mistakes.
"psr/http-server-handler": "^1.0.2",
"psr/log": "^3.0.2",
"symfony/console": "^7.4.1",
"symfony/console": "7 - 8",
Copy link

Copilot AI Feb 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint format is inconsistent with other dependencies in the project. All other third-party dependencies use caret constraints (e.g., "^1.1.6"), while only PHP uses the hyphenated range format (e.g., "8.2 - 8.5"). For consistency with the rest of the codebase, consider using a caret constraint format like "^7.4.1 || ^8.0" instead of the hyphenated range.

Suggested change
"symfony/console": "7 - 8",
"symfony/console": "^7.0 || ^8.0",

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants