Implemented resolving AssemblyMetadata, build configuration format strings and build error on dirty repo #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps build time constant until Visual Studio Solution is reloaded)
…sep>:<ref>} added
…itory contains modified (dirty)
…nsensitive Regex match for <ref>
…o avoid error message "Revision ID cannot be truncated to dotted-numeric"
Contributor
Author
|
Hello Ives, I added another patch to avoid the error message "Revision ID cannot be truncated to dotted-numeric" when the repository was empty and did not yet receive a tag. I can't tell if the solution I have chosen with 56485af is the way to go, but it works for the issue I currently had. Best regards, |
Owner
|
Just wanted to give a quick feedback. I'm very busy with other time-critical projects at the moment but these changes sound interesting and I'll take a look at them. Please don't be too sad if I won't make it anymore this year. |
Contributor
Author
|
Thanks for your feedback, Yves. I made a local build and can work with it for now. Take your time. |
Contributor
Author
|
Merged latest changes and fixed conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Yves,
I have extended Net Revision Task with the following changes:
AssemblyMetadataattributes value format strings (enabled by default)GetVersion()is called (otherwise the build time stays constant until the Solution is reloaded){bconf},{BCONF}and{bconf:<sep>:<ref>}format strings to resolve build configuration namesPlease let me know if you don't agree with the changes or see potential for optimizations.
Best regards,
Mark