ci: replace archived actions-rs/toolchain with dtolnay/rust-toolchain - #2291
Open
boleklebovski wants to merge 1 commit into
Open
ci: replace archived actions-rs/toolchain with dtolnay/rust-toolchain#2291boleklebovski wants to merge 1 commit into
boleklebovski wants to merge 1 commit into
Conversation
actions-rs has been archived since 2022 and runs on the removed Node 12 runtime. Move the four Rust workflows to dtolnay/rust-toolchain and bring the two stragglers in line with the checkout@v4 / cache@v4 used elsewhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Four Rust workflows install their toolchain with
actions-rs/toolchain@v1:.github/workflows/build-and-test-rust.yml.github/workflows/test-merkle-tree.yml.github/workflows/test-risc-zero.yml.github/workflows/test-sp1.ymlThe
actions-rsorganisation has been archived since 2022 and its actions are pinned to the Node 12 runtime, which GitHub has removed. These steps emit deprecation annotations on every run today and are a standing breakage risk rather than a cosmetic issue.Two more stragglers are inconsistent with the rest of the repo, which already standardises on v4:
lint-contracts.yml:18—actions/checkout@v2(every other workflow here uses@v4)build-and-test-rust.yml:43,109—actions/cache@v3Fix
actions-rs/toolchain@v1→dtolnay/rust-toolchain, the de-facto successorbuild-and-test-rust.yml:@1.88.0(the ref is the toolchain), keepingcomponents: rustfmt, clippytoolchain: stablejobs:@stableoverride: trueis dropped becausedtolnay/rust-toolchainalways makes the installed toolchain the default — the previous behaviour is preservedactions/checkout@v2→@v4andactions/cache@v3→@v4, matching what the other 10 workflows in this repo already useNet effect is 11 lines across 5 files; no job names, triggers, or build commands change.
Verification
dtolnay/rust-toolchain@1.88.0confirmed to exist as a ref (GET /git/ref/heads/1.88.0→ 200), so the pinned Rust version is unchangeduses/withcame out as intendedgrepconfirms noactions-rs,checkout@v1..v3orcache@v1..v3references remainCI-only change: no application code is touched.