-
Notifications
You must be signed in to change notification settings - Fork 392
feat(aggregation-mode): retry bump and sending proofs on-chain after proof aggregation #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JuArce
merged 26 commits into
staging
from
feataggmode/retry-proof-bump-send-proof-verification-contract
Jan 6, 2026
Merged
feat(aggregation-mode): retry bump and sending proofs on-chain after proof aggregation #2211
JuArce
merged 26 commits into
staging
from
feataggmode/retry-proof-bump-send-proof-verification-contract
Jan 6, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
I'd add a WARN log when there is an error. Ie "Error when ... Retrying in ..." |
05f1613 to
e828d99
Compare
…proof-bump-send-proof-verification-contract
MarcosNicolau
approved these changes
Jan 6, 2026
JuArce
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a retry logic with exponential backoff.
How to test
Normal workflow
Failure after retries
Do the same steps as before, but before step 4, go to the Docker container which maps the port 8545 (usually a
el-X-geth-lighthouse) and shut it down.Success after retries
The same as before, but when you see the first
Started waiting until we can submit the aggregated proof.log, then start the container.Type of change
Please delete options that are not relevant.
Checklist
testnet, everything else tostaging