Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 2,411-line explainer test module mixed prompt construction, output parsing, address handling, transaction flows, state reads, and batch execution. Split it into six focused modules under
tests/ai_explainer/, and extract Telegram, alert, dispatch, and Web3 tests fromtest_utils.pyinto dedicated files.Consolidate repeated LLM provider and HTTP response mocks, share address-test setup, and correct the missing-Telegram-credentials test to assert that no POST request is sent. Preserve every existing test case and its assertions, with that intentional correction. Shared builders have public names, and response mocks explicitly configure
raise_for_status. The cleanup removes 75 lines overall.Validation:
uv run ruff check .uv run ruff format --check .uv run ty checkgit diff --check