Prevent MERGE replay after ambiguous commit - #256
Closed
KirillKurdyukov wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
What is the current behavior?
If
Connection.commit()throws a normally retryable YDB error,YdbMergeSinktreats the transaction as uncommitted and can replay the buffered MERGE on a new connection even though the commit outcome is ambiguous.What is the new behavior?
Connection.commit().ABORTEDfrom commit, and verifies one connection, batch execution, and commit invocation.Validation
mvn -f ydb-trino-adapter/pom.xml -DskipTests compile.mvn -f ydb-trino-adapter/pom.xml -Dtest=TestYdbMergeSink test— 1 run, 0 failures, 0 errors, 0 skipped.599332520f9ec08edf57634fa18266a1c3fda83a.testMerge*, smoketestMerge, and full suite were not run because the existing Colima runtime is broken (colima status:error retrieving current runtime: empty value; Docker socket unavailable). The full GitHub Actions suite is required for this PR.