Rework unpacker to use the null termination of messages#97
Draft
ksunden wants to merge 2 commits intoyaq-project:mainfrom
Draft
Rework unpacker to use the null termination of messages#97ksunden wants to merge 2 commits intoyaq-project:mainfrom
ksunden wants to merge 2 commits intoyaq-project:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative approach to #92.
Unfortunately, in doing this I discovered a small protocol error in
yaqcthat is hard to work around.Namely, we do not send the termination Avro null frame during the handshaking process.
This means that for handshaking (and only handshaking) using the null terminator is not 100% correct
This can be corrected for, but introduces a backwards incompatiblity that I would like to work around if we can.