Skip to content

Fix windows CI arm runner#1288

Draft
AntoinePrv wants to merge 2 commits intoxtensor-stack:masterfrom
AntoinePrv:fix-win-arm
Draft

Fix windows CI arm runner#1288
AntoinePrv wants to merge 2 commits intoxtensor-stack:masterfrom
AntoinePrv:fix-win-arm

Conversation

@AntoinePrv
Copy link
Copy Markdown
Contributor

No description provided.

@AntoinePrv AntoinePrv marked this pull request as draft April 3, 2026 14:45
@AntoinePrv AntoinePrv marked this pull request as draft April 3, 2026 14:45
On MSVC ARM, all NEON vector types (uint8x16_t, int8x16_t, etc.) are
typedefs to __n128, which causes duplicate template specializations and
tuple type collisions in the register-type-based dispatchers.

Replace register-type dispatchers with scalar-type dispatchers (uint8_t,
int8_t, etc.) which are always distinct. Add neon_scalar_t trait to
normalize platform-specific type aliases (char, long) to fixed-width
types for reliable index_of lookups.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@serge-sans-paille
Copy link
Copy Markdown
Contributor

There's a conflict with #1285 . I prefer your approach as it's more modern C++, but let's be polite and also honor the author of #1285 who already put effort into this. Would you be ok to wait for me to merge their PR, and then you'd update it with yours?

@AntoinePrv
Copy link
Copy Markdown
Contributor Author

@serge-sans-paille sorry, I did not saw the other PR. I noticed the windows-arm was not running ARM in #1287.
The author can also pick from this PR if they want, either is fine for me.

From a CI perspective, it seems the Github action ilammy/msvc-dev-cmd can be called with arm64, which minimize the workflow changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants