ci: add clang-cl Windows CI jobs#1283
Merged
serge-sans-paille merged 1 commit intoxtensor-stack:masterfrom Apr 3, 2026
Merged
Conversation
serge-sans-paille
approved these changes
Mar 27, 2026
Contributor
serge-sans-paille
left a comment
serge-sans-paille
left a comment
There was a problem hiding this comment.
I thought you would add the /fp:fast configuration in the associated patch, but that's fine if you keep it in this one too.
Minor nits otherwise looks good.
.github/workflows/windows.yml
Outdated
| uses: actions/checkout@v3 | ||
| - name: Setup | ||
| run: | | ||
| cmake -B _build -DBUILD_TESTS=ON -DDOWNLOAD_DOCTEST=ON -DBUILD_BENCHMARK=${{ matrix.config.benchmark }} -DBUILD_EXAMPLES=${{ matrix.config.examples }} -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_CXX_FLAGS="${{ matrix.config.flags }}" -G Ninja |
Contributor
There was a problem hiding this comment.
nit: please make this multiline with escaped backslashes so that's it's easier to read, much like https://github.com/xtensor-stack/xsimd/blob/master/.github/workflows/linux.yml#L108
.github/workflows/windows.yml
Outdated
| cmake -B _build -DBUILD_TESTS=ON -DDOWNLOAD_DOCTEST=ON -DBUILD_BENCHMARK=${{ matrix.config.benchmark }} -DBUILD_EXAMPLES=${{ matrix.config.examples }} -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=clang-cl -DCMAKE_CXX_COMPILER=clang-cl -DCMAKE_CXX_FLAGS="${{ matrix.config.flags }}" -G Ninja | ||
| - name: Build | ||
| run: | | ||
| cmake --build _build |
Contributor
There was a problem hiding this comment.
nit: no need to use the multiline mode here and below
.github/workflows/windows.yml
Outdated
| cmake --build _build | ||
| - name: Testing xsimd | ||
| run: | | ||
| cd _build && ./test/test_xsimd |
Contributor
There was a problem hiding this comment.
nit: single-line ./_build/test/test_xsimd
DiamonDinoia
force-pushed
the
ci/clang-cl-windows
branch
2 times, most recently
from
012ab77 to
f126e92
Compare
Contributor
|
LGTM! I'll merge that one and the fasgt-math patch right afterward once I'm happy with both. |
Contributor
|
Can you rebase on |
DiamonDinoia
force-pushed
the
ci/clang-cl-windows
branch
3 times, most recently
from
6c0ad79 to
b75e659
Compare
Add clang-cl builds for AVX2 and /fp:fast configurations using a strategy matrix to avoid duplication. Uses cmake -B for cleaner build commands.
DiamonDinoia
force-pushed
the
ci/clang-cl-windows
branch
from
b75e659 to
694a03b
Compare
serge-sans-paille
merged commit f9079f1
into
xtensor-stack:master
72 of 73 checks passed
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/fp:fastconfigurationscmake -B _build/cmake --build _buildstyle for cleaner build commandsSplit from #1276 per review feedback — the CI additions are independent from the fast-math barrier fix.