[test] Improve testing logging and accuracy #1246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Is it ready to merge? |
Contributor
Author
|
On Thu, Jan 15, 2026 at 08:05:01AM -0800, Johan Mabille wrote:
●JohanMabille left a comment [1](xtensor-stack/xsimd#1246)
Is it ready to merge?
No, I'd like to generalize and cleanup the test code.
|
serge-sans-paille
force-pushed
the
bug/1244
branch
3 times, most recently
from
5116e69 to
7e61d27
Compare
Otherwise 512bit floats are never tested.
Logging only the number of diff does not help solving or reproducing bug, so log every comparison instead. Get rid of usuned types / functions from test_utils.h No functional change intended.
serge-sans-paille
force-pushed
the
bug/1244
branch
from
7e61d27 to
c6e4981
Compare
Contributor
Author
|
@JohanMabille looks good now :-) There are probably many other stuff to deal with, but I'm stopping here for that one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.