ci: test changed formulas on pull requests#10
Merged
Conversation
There was a problem hiding this comment.
FennoAI Review — PR #10: CI to test changed formulas
Solid workflow overall: permissions: contents: read, no secrets, pull_request (not pull_request_target), concurrency with cancel-in-progress, base/head-SHA-pinned diff, NUL-safe path parsing, and fail-fast: false. The empty-module path is handled correctly (jq select(length > 0) filters the empty line → has_modules=false). Findings below are hardening and maintainability suggestions; inline comments carry the specifics.
Key points
- Fork-PR untrusted execution (inherent): on
pull_request,llar testruns fork-controlled formula recipes. The read-only, secret-free posture is correct; residual risk is runner abuse. Recommend enabling "Require approval for all outside collaborators" in repo settings. (see inline on the llar checkout / test steps) - Supply-chain / reproducibility:
goplus/llaris pinned to mutablemain. (inline, line 93) - Performance: Go cache disabled + llar rebuilt on every matrix job; matrix can fan out to
4 × Njobs (incl. scarce macOS runners) with no cap. (inline, lines 101, 57) - Injection hygiene:
${{ matrix.module }}is interpolated unquoted into therun:script. (inline, line 116)
Cannot be placed inline (file not in this diff)
.claude/skills/write-formula/SKILL.md:638tells authors to validate locally withllar make, but CI gates withllar test --os/--arch(test.yml:116). Contributors following the guide run a different command than the PR gate. Recommend reconciling the guide with the CI command.- The README does not mention the new PR gate. A brief "Contributing / CI" note (detects changed
owner/repomodules, runsllar testacross linux/darwin × amd64/arm64) would help contributors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add pull-request validation for changed LLAR formula modules.
The implementation includes:
<owner>/<repo>module roots that containversions.json.llar teston native Linux and Darwinamd64andarm64runners.llarfromgoplus/llarand pass the selected OS and architecture to each test.llar testcan enumerate it.This gives formula changes target-platform validation without running unrelated modules.