fix(ixgo): export comparator classfile package#156
Conversation
There was a problem hiding this comment.
Review: fix(ixgo): export comparator classfile package
No blocking issues. The change correctly registers github.com/goplus/llar/cmp with the ixgo interpreter so .gox comparators loaded outside a Go module can resolve their imports from the in-memory registry instead of falling back to on-disk (go/build) resolution, which fails without a module context. The new TestLoadComparator_OutsideModule exercises exactly this path via t.Chdir(t.TempDir()), and I verified the assertion matches the semver-based CJSON_cmp.gox testdata.
Verified:
- Generated
export.gomatches the existingformula/export.gopattern and declares all exported symbols ofcmp(CmpApp,Gopt_CmpApp_Main,GopPackage).Depscorrectly lists onlymod/module(the sole import ofcmp/cmp.go). pkgs.goblank import is alphabetized within the llar group;//go:generatedirective placed beside the siblingformuladirective.go build ./internal/ixgo/...succeeds.filepath.Abs(...)is captured beforet.Chdir, so the path resolution is correct.
Not verified: go test ./internal/modules/ could not run to completion in the sandbox due to a pre-existing ixgo link error (math/rand/v2.globalRand) unrelated to this PR.
The inline comments below are minor, optional polish only.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
No description provided.