ci: pin latest LLGo main revision#2
Merged
zhouguangyuan0718 merged 1 commit intoJul 23, 2026
Conversation
zhouguangyuan0718
marked this pull request as ready for review
July 23, 2026 08:14
There was a problem hiding this comment.
Review summary
This PR advances the pinned LLGo revision in ci/llgo-size/llgo-version.env from d726187… to 9b3f60c1ad555ae190f4545b9b1acad4899e598f — a one-line config change that deliberately triggers the binary-size benchmark workflow, exactly as the file's own comment describes.
I ran code-quality, performance, security, and documentation-accuracy passes over the diff. No blocking issues found.
- Well-formed pin: the new value is a valid 40-char lowercase hex SHA, satisfying the workflow's
^[0-9a-f]{40}$validation. The.envsyntax stays valid forsource, andLLGO_REPOSITORY,GO_VERSION,LLVM_VERSIONare untouched. - Supply chain: the new SHA is a real, ancestrally-linked commit on
xgo-dev/llgo(a merge commit whose first parent is the previous pin) — a normal forward advance on the official upstream, not a redirect to a fork or unrelated history. It is an immutable pin, not a mutable branch/tag. - Docs: no documentation quotes either the old or new SHA, so
README.md/docs/llgo-binary-size-handoff.mdremain accurate.report.shreads the value from the environment at runtime and is unaffected.
Notes (non-blocking, not introduced by this PR)
- The file comment asks to keep the revision "compatible with
GO_VERSIONandLLVM_VERSION". Whether9b3f60c…actually builds against Go 1.26.2 / LLVM 19 can only be confirmed by the CI run itself — not verifiable from the diff. Please confirm the workflow passes before merging. - Pre-existing hardening opportunity in
.github/workflows/llgo-binary-size.yml: the workflow declares top-levelpermissions: contents: writeand runs onpull_request. The secret-bearing publish/deploy steps are correctly gated to non-PR events, so a forked PR cannot reach them — but least privilege would favor a defaultcontents: readat the top level, elevating only within the publish step. This is unrelated to the current diff and neither introduced nor worsened by it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update the default LLGo binary-size benchmark pin from
d726187cto the latestxgo-dev/llgo:mainmerge commit9b3f60c1.This is intentionally a one-line version update; the existing workflow and Pages history remain unchanged.
Validation
9b3f60c1exists onxgo-dev/llgo:main;git diff --checkpassed for the one-file diff.