Repository navigation
Extract the native library with owner-only permissions - #772
Open
anvesha-dev wants to merge 1 commit into
Open
anvesha-dev wants to merge 1 commit into
anvesha-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnappyLoader.extractLibraryFile creates the extracted libsnappyjava file in the shared temp folder with the process umask and only adds owner bits afterwards, so under umask 000 the library that System.load maps into the JVM is left rwxrw-rw- (rwxrw-r-- under 002) until JVM exit, and another local user can overwrite it to run code in the JVM; create it as rwx------ up front on POSIX file systems instead (reproduced in Docker with JDK 21 under umask 022/002/000, the new SnappyLoaderTest case fails before and passes after).