geotiff tests: consolidate remote-hardening cluster (#2436)#2467
Open
brendancol wants to merge 1 commit into
Open
geotiff tests: consolidate remote-hardening cluster (#2436)#2467brendancol wants to merge 1 commit into
brendancol wants to merge 1 commit into
Conversation
Fold the five top-level remote-hardening files into integration/test_http_sources.py, one Section per source issue: - test_ssrf_hardening_1664.py - test_dns_rebinding_pin_issue_1846.py - test_uppercase_scheme_ssrf_2323.py - test_max_cloud_bytes_dispatcher_silent_drop_2026_05_15.py - test_open_geotiff_max_cloud_bytes_annot_2106.py The #1846 file imported the redirect-mock pool from the #1664 file; that cross-file import becomes an in-file reference now that both live in the same module. Colliding helpers are namespaced per source issue and the per-file cupy probe collapses onto the shared requires_gpu marker. No assertion changed; 74 test functions (107 collected) match the pre-consolidation total. The release-gate checklist and geotiff docs cite the new path so the checklist-parity gate stays green. Sub-PR B of issue #2436 (cluster 12, long-tail epic #2424). Tests-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2436 (Sub-PR B of two). Cluster 12 of the long-tail GeoTIFF test consolidation epic (#2424). Tests-only.
Summary
Merges five top-level remote-hardening files into
xrspatial/geotiff/tests/integration/test_http_sources.py, one Section per source issue:test_ssrf_hardening_1664.pytest_dns_rebinding_pin_issue_1846.pytest_uppercase_scheme_ssrf_2323.pytest_max_cloud_bytes_dispatcher_silent_drop_2026_05_15.pytest_open_geotiff_max_cloud_bytes_annot_2106.pyThe #1846 file imported the redirect-mock pool from the #1664 file. That cross-file import is now an in-file reference since both live in the same module. Colliding helpers are namespaced per source issue and the per-file cupy probe collapses onto the shared
requires_gpumarker. The hermetic SSRF / dispatch tests make no real network calls (getaddrinfois monkeypatched) and follow the existinghttp_scheme_caseprecedent already living under this file's module-levelrequires_loopbackmark. No assertion changed; 74 test functions (107 collected) match the pre-consolidation total.The release-gate checklist and geotiff docs cite the new path so the checklist-parity gate stays green.
Verification
pytest xrspatial/geotiff/tests/integration/test_http_sources.py -k "ssrf_1664 or dns_rebinding or 2323 or 2026_05_15 or 2106" -q: 107 passed.pytest xrspatial/geotiff/tests/ --co -q: 5890 tests collected.Test plan
integration/test_http_sources.pypass.